[devdocsgjs/main: 705/1867] Rename CookieStore to CookiesStore




commit b23b81e693b691e1c5776c72c8a6ca5e547deede
Author: Jasper van Merle <jaspervmerle gmail com>
Date:   Sun Aug 4 14:33:44 2019 +0200

    Rename CookieStore to CookiesStore

 assets/javascripts/app/app.coffee                                   | 2 +-
 assets/javascripts/app/settings.coffee                              | 3 ++-
 .../javascripts/lib/{cookie_store.coffee => cookies_store.coffee}   | 6 +++++-
 3 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/assets/javascripts/app/app.coffee b/assets/javascripts/app/app.coffee
index 1e230368..b55e552c 100644
--- a/assets/javascripts/app/app.coffee
+++ b/assets/javascripts/app/app.coffee
@@ -78,7 +78,7 @@
         .install()
       @previousErrorHandler = onerror
       window.onerror = @onWindowError.bind(@)
-      CookieStore.onBlocked = @onCookieBlocked
+      CookiesStore.onBlocked = @onCookieBlocked
     return
 
   bootOne: ->
diff --git a/assets/javascripts/app/settings.coffee b/assets/javascripts/app/settings.coffee
index b2734dfe..cb7e7799 100644
--- a/assets/javascripts/app/settings.coffee
+++ b/assets/javascripts/app/settings.coffee
@@ -33,7 +33,8 @@ class app.Settings
     analyticsConsent: false
 
   constructor: ->
-    @store = new CookieStore
+    @store = new CookiesStore
+    console.log @store
     @cache = {}
 
   get: (key) ->
diff --git a/assets/javascripts/lib/cookie_store.coffee b/assets/javascripts/lib/cookies_store.coffee
similarity index 76%
rename from assets/javascripts/lib/cookie_store.coffee
rename to assets/javascripts/lib/cookies_store.coffee
index 3b340571..eaf1bd4f 100644
--- a/assets/javascripts/lib/cookie_store.coffee
+++ b/assets/javascripts/lib/cookies_store.coffee
@@ -1,4 +1,8 @@
-class @CookieStore
+class @CookiesStore
+  # Intentionally called CookiesStore instead of CookieStore
+  # Calling it CookieStore causes issues when the Experimental Web Platform features flag is enabled in 
Chrome
+  # Related issue: https://github.com/freeCodeCamp/devdocs/issues/932
+
   INT = /^\d+$/
 
   @onBlocked: ->


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]