[gnome-shell/wip/carlosg/grabs-pt3: 2/4] popupMenu: Drop grabHelper.addActor() call
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/grabs-pt3: 2/4] popupMenu: Drop grabHelper.addActor() call
- Date: Fri, 19 Nov 2021 18:36:03 +0000 (UTC)
commit 66b7f594fa284cd65d1d74355368dbeb671575ea
Author: Carlos Garnacho <carlosg gnome org>
Date: Fri Nov 19 13:30:13 2021 +0100
popupMenu: Drop grabHelper.addActor() call
This no longer does what it advertises to do, and PopupMenuManager
does already handle showing/hiding of other popups in the same group
by itself. This is no longer necessary.
js/ui/popupMenu.js | 6 ------
1 file changed, 6 deletions(-)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index b95b3984e7..cbefbd91a1 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -1311,10 +1311,6 @@ var PopupMenuManager = class {
capturedEventId: menu.actor.connect('captured-event', this._onCapturedEvent.bind(this)),
};
- let source = menu.sourceActor;
- if (source)
- this._grabHelper.addActor(source);
-
if (position == undefined)
this._menus.push(menudata);
else
@@ -1333,8 +1329,6 @@ var PopupMenuManager = class {
menu.disconnect(menudata.openStateChangeId);
menu.disconnect(menudata.destroyId);
- if (menu.sourceActor)
- this._grabHelper.removeActor(menu.sourceActor);
this._menus.splice(position, 1);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]