[gnome-builder] flatpak: ignore system installations when locating remote



commit f8c54abbae827e8f2d75ec6e22d80c451b49c55a
Author: Christian Hergert <chergert redhat com>
Date:   Tue Nov 16 15:25:48 2021 -0800

    flatpak: ignore system installations when locating remote
    
    We don't want to find a remote that is on a system installation because we
    cant modify those. We need to ensure we fallback to our private
    installation where we have write access from the sandbox.

 src/plugins/flatpak/daemon/ipc-flatpak-service-impl.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/plugins/flatpak/daemon/ipc-flatpak-service-impl.c 
b/src/plugins/flatpak/daemon/ipc-flatpak-service-impl.c
index 30899cdac..0b56a2d15 100644
--- a/src/plugins/flatpak/daemon/ipc-flatpak-service-impl.c
+++ b/src/plugins/flatpak/daemon/ipc-flatpak-service-impl.c
@@ -890,7 +890,10 @@ find_remote_for_ref (IpcFlatpakServiceImpl  *self,
       Install *install = g_ptr_array_index (self->installs_ordered, i);
       g_autoptr(GPtrArray) remotes = flatpak_installation_list_remotes (install->installation, NULL, NULL);
 
-      if (remotes == NULL)
+      /* Ignore if failure or this is a system installation (as we can't install
+       * anything for that).
+       */
+      if (remotes == NULL || !flatpak_installation_get_is_user (install->installation))
         continue;
 
       for (guint j = 0; j < remotes->len; j++)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]