[nautilus] file-conflict-dialog: Prevent rename button appearing prematurely



commit b002cb626d1376e1231dcd888f06b843e16294bc
Author: Joshua Lee <lee son wai gmail com>
Date:   Sun Nov 14 18:33:38 2021 +0000

    file-conflict-dialog: Prevent rename button appearing prematurely
    
    Commit 38803058cbc8257f7b53fff9dd8c771bf7512c87 introduced calls to
    gtk_widget_show_all(), which causes the 'Rename' button to appear prematurely
    when the dialog is created. Fix this by using gtk_widget_show() instead.
    
    Take this opportunity to modify the call when creating the app chooser dialog
    too as gtk_widget_show_all() doesn't exist in GTK 4.

 src/nautilus-operations-ui-manager.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/nautilus-operations-ui-manager.c b/src/nautilus-operations-ui-manager.c
index 99e38b8ea..831861bce 100644
--- a/src/nautilus-operations-ui-manager.c
+++ b/src/nautilus-operations-ui-manager.c
@@ -495,7 +495,7 @@ run_file_conflict_dialog (gpointer user_data)
                                         data);
 
     g_signal_connect (data->dialog, "response", G_CALLBACK (on_conflict_dialog_response), data);
-    gtk_widget_show_all (GTK_WIDGET (data->dialog));
+    gtk_widget_show (GTK_WIDGET (data->dialog));
 
     g_list_free (files);
 
@@ -586,7 +586,7 @@ open_file_in_application (gpointer user_data)
     gtk_app_chooser_dialog_set_heading (GTK_APP_CHOOSER_DIALOG (dialog), heading);
 
     g_signal_connect (dialog, "response", G_CALLBACK (on_app_chooser_response), data);
-    gtk_widget_show_all (dialog);
+    gtk_widget_show (dialog);
 
     return G_SOURCE_REMOVE;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]