[gimp/wip/Jehan/layers-dockable-refresh: 86/87] app: fix "%d items selected" label when multi-selecting.
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp/wip/Jehan/layers-dockable-refresh: 86/87] app: fix "%d items selected" label when multi-selecting.
- Date: Mon, 15 Nov 2021 01:38:12 +0000 (UTC)
commit 74e78da7e9c43669bccb42a257f04c61c49c73ec
Author: Jehan <jehan girinstud io>
Date: Wed Nov 10 23:12:21 2021 +0100
app: fix "%d items selected" label when multi-selecting.
This got broken in commit f66bd2418c because you want to always throw
the signal. Yet the context must only be updated with a grid view in the
GimpContainerEditor. Now it should work correctly (hopefully!).
app/widgets/gimpcontainereditor.c | 3 ++-
app/widgets/gimpcontainerview.c | 5 ++---
2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/app/widgets/gimpcontainereditor.c b/app/widgets/gimpcontainereditor.c
index 2e1acfada0..0c3cd7509f 100644
--- a/app/widgets/gimpcontainereditor.c
+++ b/app/widgets/gimpcontainereditor.c
@@ -455,7 +455,8 @@ gimp_container_editor_select_items (GimpContainerView *view,
if (klass->select_item)
klass->select_item (editor, viewable);
- if (editor->priv->container)
+ if (editor->priv->container &&
+ editor->priv->view_type == GIMP_VIEW_TYPE_GRID)
{
const gchar *signal_name;
GType children_type;
diff --git a/app/widgets/gimpcontainerview.c b/app/widgets/gimpcontainerview.c
index 3caecca436..1969b761df 100644
--- a/app/widgets/gimpcontainerview.c
+++ b/app/widgets/gimpcontainerview.c
@@ -714,9 +714,8 @@ gimp_container_view_multi_selected (GimpContainerView *view,
g_return_val_if_fail (GIMP_IS_CONTAINER_VIEW (view), FALSE);
- if (! gimp_container_view_are_selected_items (view, items))
- g_signal_emit (view, view_signals[SELECT_ITEMS], 0,
- items, items_data, &success);
+ g_signal_emit (view, view_signals[SELECT_ITEMS], 0,
+ items, items_data, &success);
return success;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]