[gtk/wip/carlosg/no-ping-serials-for-input] gdk/wayland: Do not use xdg_wm_base.ping serials as "user input" serials




commit bf7b73c16badd8403d6484a6b60162d4912a24af
Author: Carlos Garnacho <carlosg gnome org>
Date:   Thu Nov 4 14:40:21 2021 +0100

    gdk/wayland: Do not use xdg_wm_base.ping serials as "user input" serials
    
    Ping/pong serials are not meant to be interpreted as user input serials
    (e.g. those given back later to the compositor on grabs). As a matter
    of fact, Mutter uses a different count (i.e. timestamps) in these, so
    using these serials may confuse the compositor into denying certain
    operations like DnD.

 gdk/wayland/gdkdisplay-wayland.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/gdk/wayland/gdkdisplay-wayland.c b/gdk/wayland/gdkdisplay-wayland.c
index 8828d6e987..70743dd3f3 100644
--- a/gdk/wayland/gdkdisplay-wayland.c
+++ b/gdk/wayland/gdkdisplay-wayland.c
@@ -132,8 +132,6 @@ xdg_wm_base_ping (void               *data,
 {
   GdkWaylandDisplay *display_wayland = data;
 
-  _gdk_wayland_display_update_serial (display_wayland, serial);
-
   GDK_NOTE (EVENTS,
             g_message ("ping, shell %p, serial %u\n", xdg_wm_base, serial));
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]