[nautilus/gnome-40] application: Stop updating previewer on windows focus



commit 3b746692607c3a9d695de70964610be46e70e5e4
Author: Felipe Borges <felipeborges gnome org>
Date:   Wed May 26 10:57:43 2021 +0200

    application: Stop updating previewer on windows focus
    
    It is a very specific corner case when the previewer (sushi) is
    being used alongside multiple windows of Nautilus.
    
    This causes a race condition when the change of active-window
    notification arrives out of order with the check for the previewer
    "Visible" property, making the update process loop when previewing
    videos.
    
    Fixes #1823
    
    
    (cherry picked from commit 0b7a7f95f84f775be38e5533a37f93567fba2b59)

 src/nautilus-application.c | 15 ---------------
 1 file changed, 15 deletions(-)
---
diff --git a/src/nautilus-application.c b/src/nautilus-application.c
index 73153f548..5deae5cc9 100644
--- a/src/nautilus-application.c
+++ b/src/nautilus-application.c
@@ -1260,20 +1260,6 @@ update_previewer_selection (NautilusApplication *self,
     }
 }
 
-static void
-on_application_active_window_changed (NautilusApplication *self,
-                                      GParamSpec          *pspec,
-                                      gpointer             user_data)
-{
-    GtkWindow *window;
-
-    window = gtk_application_get_active_window (GTK_APPLICATION (self));
-    if (NAUTILUS_IS_WINDOW (window))
-    {
-        update_previewer_selection (self, NAUTILUS_WINDOW (window));
-    }
-}
-
 static void
 on_application_shutdown (GApplication *application,
                          gpointer      user_data)
@@ -1358,7 +1344,6 @@ nautilus_application_startup_common (NautilusApplication *self)
 
     nautilus_profile_end (NULL);
 
-    g_signal_connect (self, "notify::active-window", G_CALLBACK (on_application_active_window_changed), 
NULL);
     g_signal_connect (self, "shutdown", G_CALLBACK (on_application_shutdown), NULL);
 
     g_signal_connect_object (gtk_icon_theme_get_default (),


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]