[gnome-software/1251-sources-for-an-app-randomly-appeared-in-header-on-updates-tab] gs-details-page: Refresh only when being selected
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1251-sources-for-an-app-randomly-appeared-in-header-on-updates-tab] gs-details-page: Refresh only when being selected
- Date: Fri, 21 May 2021 09:11:20 +0000 (UTC)
commit f9d2ec53180692e2415cea92536287beb14f862f
Author: Milan Crha <mcrha redhat com>
Date: Fri May 21 11:09:38 2021 +0200
gs-details-page: Refresh only when being selected
The second attempt, to not refresh the page when a reload is called,
which can happen for example after Flatpak changes from the command
line.
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1251
src/gs-details-page.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 728f0e5bb..8afe5b8b7 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -543,10 +543,10 @@ gs_details_page_switch_to_idle (gpointer user_data)
if (gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS) {
gs_page_switch_to (GS_PAGE (self));
gs_page_scroll_up (GS_PAGE (self));
- }
- /* update widgets */
- gs_details_page_refresh_all (self);
+ /* update widgets */
+ gs_details_page_refresh_all (self);
+ }
g_object_unref (self);
return G_SOURCE_REMOVE;
@@ -2261,7 +2261,7 @@ static void
gs_details_page_reload (GsPage *page)
{
GsDetailsPage *self = GS_DETAILS_PAGE (page);
- if (self->app != NULL)
+ if (self->app != NULL && gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS)
gs_details_page_load_stage1 (self);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]