[gimp] Issue #6257: Race condition bug in meson build.
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Issue #6257: Race condition bug in meson build.
- Date: Thu, 20 May 2021 02:35:50 +0000 (UTC)
commit 9c6776fbe41122ce741b18ec47f28587b5e3d360
Author: Jehan <jehan girinstud io>
Date: Thu May 20 04:32:20 2021 +0200
Issue #6257: Race condition bug in meson build.
Argh! My previous commit logics was right, but should have been applied
to the Windows builds (where the issue happens). That's what happens
when I hack too late at night!
.gitlab-ci.yml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a2997a7ae1..0d9e5aaaba 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -233,13 +233,7 @@ gimp-clang-debian:
clang libomp-dev
- meson _build
--prefix="${INSTALL_PREFIX}"
- # This is absolute ugly but is the current trick to handle issue
- # #6257 which is a race condition in the meson build. When we have a
- # failure because of this, "git-version.h" will still have been
- # created, yet after a depending target is being built. So all we
- # have to do is re-run `ninja`. If the second attempt fails too,
- # then it's another issue.
- - ninja -C _build || ninja -C _build
+ - ninja -C _build
- ninja -C _build test
## WINDOWS 64-bit CI (native MSYS2) ##
@@ -412,8 +406,14 @@ gimp-win64:
script:
- export PATH="`pwd`/.local/bin:$PATH"
- mkdir _build && cd _build
+ # This is absolute ugly but is the current trick to handle issue
+ # #6257 which is a race condition in the meson build. When we have a
+ # failure because of this, "git-version.h" will still have been
+ # created, yet after a depending target is being built. So all we
+ # have to do is re-run `ninja`. If the second attempt fails too,
+ # then it's another issue.
- echo 'crossroad meson ..
- -Dgtk-doc=false && ninja install &&
+ -Dgtk-doc=false && (ninja || ninja) && ninja install &&
cp -fr $CROSSROAD_PREFIX/ ../gimp-prefix/
' |
crossroad w64 gimp --run="-"
@@ -478,7 +478,7 @@ gimp-win32:
- export PATH="`pwd`/.local/bin:$PATH"
- mkdir _build && cd _build
- echo 'crossroad meson ..
- -Dwmf=disabled -Dmng=disabled -Dgtk-doc=false && ninja install &&
+ -Dwmf=disabled -Dmng=disabled -Dgtk-doc=false && (ninja || ninja) && ninja install &&
cp -fr $CROSSROAD_PREFIX/ ../gimp-prefix/
' |
crossroad w32 gimp --run="-"
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]