[libsoup/wip/http2] http2: Ensure signals are disconnected on destroy



commit 251517fdbeb60d45fd5f470fa048b2f0b64b4d45
Author: Patrick Griffis <pgriffis igalia com>
Date:   Mon May 17 12:01:36 2021 -0500

    http2: Ensure signals are disconnected on destroy

 libsoup/http2/soup-client-message-io-http2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/libsoup/http2/soup-client-message-io-http2.c b/libsoup/http2/soup-client-message-io-http2.c
index e7caaa13..b5e2c7df 100644
--- a/libsoup/http2/soup-client-message-io-http2.c
+++ b/libsoup/http2/soup-client-message-io-http2.c
@@ -315,8 +315,6 @@ memory_stream_need_more_data_callback (SoupBodyInputStreamHttp2 *stream,
         SoupHTTP2MessageData *data = (SoupHTTP2MessageData*)user_data;
         GError *error = NULL;
 
-        g_debug ("memory_stream_want_read_callback write=%d read=%d", nghttp2_session_want_write 
(data->io->session), nghttp2_session_want_read (data->io->session));
-
         io_read_or_write (data->io, blocking, cancellable, &error);
 
         return error;
@@ -755,6 +753,9 @@ add_message_to_io_data (SoupClientMessageIOHTTP2        *io,
 static void
 soup_http2_message_data_free (SoupHTTP2MessageData *data)
 {
+        if (data->body_istream)
+                g_signal_handlers_disconnect_by_data (data->body_istream, data);
+
         g_clear_pointer (&data->item, soup_message_queue_item_unref);
         g_clear_object (&data->body_istream);
         g_clear_object (&data->decoded_data_istream);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]