[libsoup] client-message-io-http1: disconnect the right signal



commit 3422d86b5398729221874e260c560f0cc600665c
Author: Carlos Garcia Campos <cgarcia igalia com>
Date:   Sat May 15 16:30:59 2021 +0200

    client-message-io-http1: disconnect the right signal
    
    It's not connection signals, it's istream ones, since it's
    response_network_stream_read_data_cb() the callback being called after
    io data finished.

 libsoup/soup-client-message-io-http1.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/libsoup/soup-client-message-io-http1.c b/libsoup/soup-client-message-io-http1.c
index d0e87b32..32dbf7bb 100644
--- a/libsoup/soup-client-message-io-http1.c
+++ b/libsoup/soup-client-message-io-http1.c
@@ -71,7 +71,6 @@ soup_client_message_io_complete (SoupClientMessageIOHTTP1 *io,
                                  SoupMessage *msg,
                                  SoupMessageIOCompletion completion)
 {
-        SoupConnection* conn;
         SoupMessageIOCompletionFn completion_cb;
         gpointer completion_data;
 
@@ -79,11 +78,11 @@ soup_client_message_io_complete (SoupClientMessageIOHTTP1 *io,
         completion_data = io->base.completion_data;
 
         msg = g_object_ref (msg);
-        conn = soup_message_get_connection (msg);
-        g_signal_handlers_disconnect_by_data (conn, msg);
+        if (io->base.istream)
+                g_signal_handlers_disconnect_by_data (io->base.istream, msg);
         if (io->base.body_ostream)
                 g_signal_handlers_disconnect_by_data (io->base.body_ostream, msg);
-        soup_connection_message_io_finished (conn, msg);
+        soup_connection_message_io_finished (soup_message_get_connection (msg), msg);
         if (completion_cb)
                 completion_cb (G_OBJECT (msg), completion, completion_data);
         g_object_unref (msg);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]