[damned-lies] chore: flake8 fixes on teams
- From: Claude Paroz <claudep src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [damned-lies] chore: flake8 fixes on teams
- Date: Fri, 7 May 2021 12:21:44 +0000 (UTC)
commit 7afa0c93074a5af41f12f6c66212ac3462c4bc19
Author: Guillaume Bernard <associations guillaume-bernard fr>
Date: Fri Apr 30 11:28:41 2021 +0200
chore: flake8 fixes on teams
teams/forms.py | 2 +-
teams/models.py | 3 +--
teams/tests.py | 12 ++++++------
teams/views.py | 56 ++++++++++++++++++++++++++++----------------------------
4 files changed, 36 insertions(+), 37 deletions(-)
---
diff --git a/teams/forms.py b/teams/forms.py
index a8622a49..a64bb4d6 100644
--- a/teams/forms.py
+++ b/teams/forms.py
@@ -11,7 +11,7 @@ class EditTeamDetailsForm(forms.ModelForm):
model = Team
fields = ('webpage_url', 'mailing_list', 'mailing_list_subscribe', 'use_workflow', 'presentation')
widgets = {
- 'webpage_url': forms.TextInput(attrs={'size': 60, 'class': 'form-control'}),
+ 'webpage_url': forms.TextInput(attrs={'size': 60, 'class': 'form-control'}),
'mailing_list': forms.TextInput(attrs={'size': 60, 'class': 'form-control'}),
'mailing_list_subscribe': forms.TextInput(attrs={'size': 60, 'class': 'form-control'}),
'presentation': forms.Textarea(attrs={'cols': 60, 'class': 'form-control'}),
diff --git a/teams/models.py b/teams/models.py
index 5f939b5b..188925b9 100644
--- a/teams/models.py
+++ b/teams/models.py
@@ -92,8 +92,7 @@ class Team(models.Model):
""" Return True if user is allowed to edit this team
user is a User (from request.user), not a Person
"""
- return (user.is_authenticated and
- user.username in [p.username for p in self.get_coordinators()])
+ return user.is_authenticated and user.username in [p.username for p in self.get_coordinators()]
def fill_role(self, role, person):
""" Used by TeamManager to prefill roles in team """
diff --git a/teams/tests.py b/teams/tests.py
index 138ad941..f95409a4 100644
--- a/teams/tests.py
+++ b/teams/tests.py
@@ -36,7 +36,7 @@ class TeamsAndRolesMixin:
cls.pc = Person.objects.create(
first_name='John', last_name='Committer',
email='jc alinsudesonpleingre fr', username='jc',
- last_login=datetime.now() - timedelta(days=30*6-1)
+ last_login=datetime.now() - timedelta(days=30 * 6 - 1)
)
cls.pcoo = Person(
@@ -252,7 +252,7 @@ class JSONTeamsTest(TeamsAndRolesMixin, TestCase):
"""Test JSON teams interface"""
response = self.client.get(reverse('teams', args=['json']))
self.assertEqual(response.status_code, 200)
- expected_JSON = """[
+ expected_json = """[
{
"id":"fr",
"description":"French",
@@ -280,7 +280,7 @@ class JSONTeamsTest(TeamsAndRolesMixin, TestCase):
"coordinators": []
}
]"""
- self.assertJSONEqual(response.content.decode('utf-8'), expected_JSON)
+ self.assertJSONEqual(response.content.decode('utf-8'), expected_json)
class RoleTest(TeamsAndRolesMixin, TestCase):
@@ -288,13 +288,13 @@ class RoleTest(TeamsAndRolesMixin, TestCase):
def setUp(self):
super().setUp()
- self.pt.last_login = datetime.now()-timedelta(days=10) # active person
+ self.pt.last_login = datetime.now() - timedelta(days=10) # active person
self.pt.save()
- self.pr.last_login = datetime.now()-timedelta(days=30*6+1) # inactive person
+ self.pr.last_login = datetime.now() - timedelta(days=30 * 6 + 1) # inactive person
self.pr.save()
- self.pc.last_login = datetime.now()-timedelta(days=30*6-1) # active person, but in limit date
+ self.pc.last_login = datetime.now() - timedelta(days=30 * 6 - 1) # active person, but in limit date
self.pc.save()
self.role = Role.objects.get(team=self.t, person=self.pt)
diff --git a/teams/views.py b/teams/views.py
index 91fa28d8..3d11d6f0 100644
--- a/teams/views.py
+++ b/teams/views.py
@@ -28,34 +28,34 @@ def team(request, team_slug):
try:
team = Team.objects.get(name=team_slug)
mem_groups = (
- {
- 'id': 'committers',
- 'title': _("Committers"),
- 'members': team.get_committers_exact(),
- 'form': None,
- 'no_member': _("No committers")
- },
- {
- 'id': 'reviewers',
- 'title': _("Reviewers"),
- 'members': team.get_reviewers_exact(),
- 'form': None,
- 'no_member': _("No reviewers")
- },
- {
- 'id': 'translators',
- 'title': _("Translators"),
- 'members': team.get_translators_exact(),
- 'form': None,
- 'no_member': _("No translators")
- },
- {
- 'id': 'inactive',
- 'title': _("Inactive members"),
- 'members': team.get_inactive_members(),
- 'form': None,
- 'no_member': _("No inactive members")
- }
+ {
+ 'id': 'committers',
+ 'title': _("Committers"),
+ 'members': team.get_committers_exact(),
+ 'form': None,
+ 'no_member': _("No committers")
+ },
+ {
+ 'id': 'reviewers',
+ 'title': _("Reviewers"),
+ 'members': team.get_reviewers_exact(),
+ 'form': None,
+ 'no_member': _("No reviewers")
+ },
+ {
+ 'id': 'translators',
+ 'title': _("Translators"),
+ 'members': team.get_translators_exact(),
+ 'form': None,
+ 'no_member': _("No translators")
+ },
+ {
+ 'id': 'inactive',
+ 'title': _("Inactive members"),
+ 'members': team.get_inactive_members(),
+ 'form': None,
+ 'no_member': _("No inactive members")
+ }
)
except Team.DoesNotExist:
lang = get_object_or_404(Language, locale=team_slug)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]