[gnome-software: 8/29] gs-shell: Simplify some page-handling logic
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 8/29] gs-shell: Simplify some page-handling logic
- Date: Wed, 31 Mar 2021 16:03:45 +0000 (UTC)
commit 442374484a4e36e91eb1e687a5a71fb362a99c8e
Author: Philip Withnall <pwithnall endlessos org>
Date: Wed Jan 20 23:50:58 2021 +0000
gs-shell: Simplify some page-handling logic
This introduces no functional changes.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
src/gs-shell.c | 38 +++++---------------------------------
1 file changed, 5 insertions(+), 33 deletions(-)
---
diff --git a/src/gs-shell.c b/src/gs-shell.c
index 76732c6f6..ecb35c401 100644
--- a/src/gs-shell.c
+++ b/src/gs-shell.c
@@ -489,41 +489,13 @@ stack_notify_visible_child_cb (GObject *object,
mode == GS_SHELL_MODE_UPDATES);
/* do action for mode */
+ page = GS_PAGE (g_hash_table_lookup (priv->pages, page_name[mode]));
+
priv->mode = mode;
- switch (mode) {
- case GS_SHELL_MODE_OVERVIEW:
- gs_shell_clean_back_entry_stack (shell);
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "overview"));
- break;
- case GS_SHELL_MODE_INSTALLED:
- gs_shell_clean_back_entry_stack (shell);
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "installed"));
- break;
- case GS_SHELL_MODE_MODERATE:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "moderate"));
- break;
- case GS_SHELL_MODE_LOADING:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "loading"));
- break;
- case GS_SHELL_MODE_SEARCH:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "search"));
- break;
- case GS_SHELL_MODE_UPDATES:
+ if (mode == GS_SHELL_MODE_OVERVIEW ||
+ mode == GS_SHELL_MODE_INSTALLED ||
+ mode == GS_SHELL_MODE_UPDATES)
gs_shell_clean_back_entry_stack (shell);
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "updates"));
- break;
- case GS_SHELL_MODE_DETAILS:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "details"));
- break;
- case GS_SHELL_MODE_CATEGORY:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "category"));
- break;
- case GS_SHELL_MODE_EXTRAS:
- page = GS_PAGE (g_hash_table_lookup (priv->pages, "extras"));
- break;
- default:
- g_assert_not_reached ();
- }
/* show the back button if needed */
widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "button_back"));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]