[gtk/file-chooser-fixes: 2/5] layout: Be quiet about trivialities




commit b5558f3e9784eccc762ed0b4c12a385f4d7b1c3c
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Mar 27 08:59:21 2021 -0400

    layout: Be quiet about trivialities
    
    Commit 8b82993dde5bea985d added a noisy warning
    to gtk_distribute_natural_allocation to quiet a
    compiler warning. It turn out that the file chooser
    managed to trigger this warning, so make it a quiet
    return.

 gtk/gtksizerequest.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/gtk/gtksizerequest.c b/gtk/gtksizerequest.c
index bad631c022..c614088b82 100644
--- a/gtk/gtksizerequest.c
+++ b/gtk/gtksizerequest.c
@@ -698,7 +698,9 @@ gtk_distribute_natural_allocation (int               extra_space,
   int    i;
 
   g_return_val_if_fail (extra_space >= 0, 0);
-  g_return_val_if_fail (n_requested_sizes > 0, 0);
+
+  if (n_requested_sizes == 0)
+    return extra_space;
 
   spreading = g_newa (guint, n_requested_sizes);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]