[epiphany/mcatanzaro/modified-forms-assert] web-view: remove bad assert
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/modified-forms-assert] web-view: remove bad assert
- Date: Thu, 25 Mar 2021 18:49:00 +0000 (UTC)
commit adeb59da5ae7d177a3bb7016bc27990e851b82ee
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Thu Mar 25 13:47:41 2021 -0500
web-view: remove bad assert
I incorrectly assumed that a GTask becomes completed once
g_task_return() is called. In fact, it becomes completed once its
callback is invoked, which may occur later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1942814
embed/ephy-web-view.c | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index 6daa9fee7..9fc1cc28e 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -3137,7 +3137,6 @@ has_modified_forms_cb (WebKitWebView *view,
id = GPOINTER_TO_INT (g_task_get_task_data (task));
if (id == 0) {
/* We hit the timeout. Our task has already returned. */
- g_assert (g_task_get_completed (task));
goto out;
}
g_source_remove (id);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]