[orca] speechdispatcherfactory: do not set language if it is empty



commit c94d7648ec16882dd72d969db396c54e48067be3
Author: Samuel Thibault <samuel thibault ens-lyon org>
Date:   Thu Mar 25 00:28:45 2021 +0100

    speechdispatcherfactory: do not set language if it is empty
    
    In case orca is getting started without any specific locale, we may get
    an empty language. In that case we shouldn't try to pass this to
    speech-dispatcher, it would just fail (and happens to break output
    modules in non-recent versions of speech-dispatcher).

 src/orca/speechdispatcherfactory.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/speechdispatcherfactory.py b/src/orca/speechdispatcherfactory.py
index c2ecd9e30..c4a78414a 100644
--- a/src/orca/speechdispatcherfactory.py
+++ b/src/orca/speechdispatcherfactory.py
@@ -248,10 +248,11 @@ class SpeechServer(speechserver.SpeechServer):
 
     def _set_family(self, acss_family):
         lang, dialect = self._get_language_and_dialect(acss_family)
-        self._send_command(self._client.set_language, lang)
-        if dialect:
-            # Try to set precise dialect
-            self._send_command(self._client.set_language, lang + '-' + dialect)
+        if lang:
+            self._send_command(self._client.set_language, lang)
+            if dialect:
+                # Try to set precise dialect
+                self._send_command(self._client.set_language, lang + '-' + dialect)
 
         try:
             # This command is not available with older SD versions.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]