[gnome-photos/wip/rishi/dlna-renderer-fixes-00: 4/6] dlna-renderer: Don't leak the GError




commit e5fa965fa4800264d84e34041f12c775c44884d6
Author: Debarshi Ray <debarshir gnome org>
Date:   Tue Mar 23 23:16:32 2021 +0100

    dlna-renderer: Don't leak the GError
    
    https://gitlab.gnome.org/GNOME/gnome-photos/-/merge_requests/196

 src/photos-dlna-renderer.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/src/photos-dlna-renderer.c b/src/photos-dlna-renderer.c
index 18656432..56ab6a77 100644
--- a/src/photos-dlna-renderer.c
+++ b/src/photos-dlna-renderer.c
@@ -619,16 +619,18 @@ photos_dlna_renderer_unshare_all_unshare_cb (GObject *source_object,
   PhotosDlnaRenderer *self = PHOTOS_DLNA_RENDERER (source_object);
   g_autoptr (GTask) task = G_TASK (user_data);
   guint remaining;
-  GError *error = NULL;
 
   /* decrement the remaining count */
   remaining = GPOINTER_TO_UINT (g_task_get_task_data (task));
   g_task_set_task_data (task, GUINT_TO_POINTER (--remaining), NULL);
 
-  photos_dlna_renderer_unshare_finish (self, res, &error);
+  {
+    g_autoptr (GError) error = NULL;
 
-  if (error != NULL)
-    g_warning ("Unable to unshare item: %s", error->message);
+    photos_dlna_renderer_unshare_finish (self, res, &error);
+    if (error != NULL)
+      g_warning ("Unable to unshare item: %s", error->message);
+  }
 
   if (remaining == 0)
     {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]