[tracker/wip/carlosg/coverity-warnings: 13/18] libtracker-data: Plug leak




commit 62f15d71039820ed167d0cd281b041c79fb332bc
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Mar 20 13:20:04 2021 +0100

    libtracker-data: Plug leak
    
    On error paths, the GString was being leaked. Ensure we set it up
    after early returns.
    
    CID: #1501135

 src/libtracker-data/tracker-data-manager.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/libtracker-data/tracker-data-manager.c b/src/libtracker-data/tracker-data-manager.c
index 81f7bf28f..b7fc6a13f 100644
--- a/src/libtracker-data/tracker-data-manager.c
+++ b/src/libtracker-data/tracker-data-manager.c
@@ -4417,13 +4417,13 @@ data_manager_perform_cleanup (TrackerDataManager  *manager,
        const gchar *graph;
        GString *str;
 
-       str = g_string_new ("WITH referencedElements(ID) AS ("
-                           "SELECT ID FROM \"main\".Refcount ");
-
        graphs = tracker_data_manager_ensure_graphs (manager, iface, &internal_error);
        if (!graphs)
                goto fail;
 
+       str = g_string_new ("WITH referencedElements(ID) AS ("
+                           "SELECT ID FROM \"main\".Refcount ");
+
        g_hash_table_iter_init (&iter, graphs);
 
        while (g_hash_table_iter_next (&iter, (gpointer*) &graph, NULL)) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]