[gnome-applets] geyes: fix memory leak



commit e5d82ef8f6f7a6546731853e2e2e47114f0680a5
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Sun Mar 21 19:13:35 2021 +0200

    geyes: fix memory leak
    
    Coverity CID: #1502736

 gnome-applets/geyes/themes.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/gnome-applets/geyes/themes.c b/gnome-applets/geyes/themes.c
index 149e83c4c..2538d441c 100644
--- a/gnome-applets/geyes/themes.c
+++ b/gnome-applets/geyes/themes.c
@@ -121,12 +121,15 @@ load_theme (EyesApplet *eyes_applet, const gchar *theme_dir)
 
         file_name = g_strdup_printf("%s%s",theme_dir,"/config");
         theme_file = fopen (file_name, "r");
+        g_free (file_name);
+
         if (theme_file == NULL) {
                g_free (eyes_applet->theme_dir);
                eyes_applet->theme_dir = g_strdup_printf (GEYES_THEMES_DIR "Default-tiny/");
-               g_free (file_name);
+
                 file_name = g_strdup (GEYES_THEMES_DIR "Default-tiny/config");
                 theme_file = fopen (file_name, "r");
+                g_free (file_name);
         }
 
        /* if it's still NULL we've got a major problem */
@@ -164,8 +167,7 @@ load_theme (EyesApplet *eyes_applet, const gchar *theme_dir)
         eyes_applet->pupil_width = gdk_pixbuf_get_width (eyes_applet->pupil_image);
 
         fclose (theme_file);
-        g_free (file_name);
-   
+
        return TRUE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]