[dconf-editor/ricotz/vala] Reference of [GtkChild] field is handled by GtkBuilder, type must be unowned
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dconf-editor/ricotz/vala] Reference of [GtkChild] field is handled by GtkBuilder, type must be unowned
- Date: Wed, 17 Mar 2021 13:51:19 +0000 (UTC)
commit f4e4bce71139b0042c59fb7628e473448b4a32a3
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Wed Mar 17 14:50:39 2021 +0100
Reference of [GtkChild] field is handled by GtkBuilder, type must be unowned
editor/base-headerbar.vala | 14 +++++++-------
editor/base-view.vala | 4 ++--
editor/base-window.vala | 2 +-
editor/bookmarks-controller.vala | 16 ++++++++--------
editor/bookmarks-list.vala | 2 +-
editor/bookmarks.vala | 14 +++++++-------
editor/browser-infobar.vala | 2 +-
editor/browser-stack.vala | 8 ++++----
editor/delayed-setting-view.vala | 12 ++++++------
editor/key-list-box-row.vala | 18 +++++++++---------
editor/large-pathbar.vala | 4 ++--
editor/modifications-revealer.vala | 10 +++++-----
editor/notifications-revealer.vala | 2 +-
editor/overlayed-list.vala | 10 +++++-----
editor/pathentry.vala | 8 ++++----
editor/pathwidget.vala | 18 +++++++++---------
editor/registry-info.vala | 22 +++++++++++-----------
editor/registry-list.vala | 6 +++---
editor/registry-placeholder.vala | 4 ++--
editor/short-pathbar.vala | 4 ++--
20 files changed, 90 insertions(+), 90 deletions(-)
---
diff --git a/editor/base-headerbar.vala b/editor/base-headerbar.vala
index 8377a5ca..8733b791 100644
--- a/editor/base-headerbar.vala
+++ b/editor/base-headerbar.vala
@@ -20,7 +20,7 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/base-headerbar.ui")]
private class BaseHeaderBar : NightTimeAwareHeaderBar, AdaptativeWidget
{
- [GtkChild] protected Box center_box;
+ [GtkChild] protected unowned Box center_box;
construct
{
@@ -190,7 +190,7 @@ private class BaseHeaderBar : NightTimeAwareHeaderBar, AdaptativeWidget
* * quit button stack
\*/
- [GtkChild] private Stack quit_button_stack;
+ [GtkChild] private unowned Stack quit_button_stack;
protected void add_named_widget_to_quit_button_stack (Widget widget, string name)
{
@@ -214,11 +214,11 @@ private class BaseHeaderBar : NightTimeAwareHeaderBar, AdaptativeWidget
* * default widgets
\*/
- [GtkChild] private Button go_back_button;
- [GtkChild] private Separator ltr_left_separator;
- [GtkChild] private Label title_label;
- [GtkChild] private MenuButton info_button;
- [GtkChild] private Separator ltr_right_separator;
+ [GtkChild] private unowned Button go_back_button;
+ [GtkChild] private unowned Separator ltr_left_separator;
+ [GtkChild] private unowned Label title_label;
+ [GtkChild] private unowned MenuButton info_button;
+ [GtkChild] private unowned Separator ltr_right_separator;
protected void set_default_widgets_states (string? title_label_text_or_null,
bool show_go_back_button,
diff --git a/editor/base-view.vala b/editor/base-view.vala
index 542268c0..8679612a 100644
--- a/editor/base-view.vala
+++ b/editor/base-view.vala
@@ -20,7 +20,7 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/base-view.ui")]
private class BaseView : Stack, AdaptativeWidget
{
- [GtkChild] protected Grid main_grid;
+ [GtkChild] protected unowned Grid main_grid;
internal virtual bool handle_copy_text (out string copy_text)
{
@@ -109,7 +109,7 @@ private class BaseView : Stack, AdaptativeWidget
* * notifications
\*/
- [GtkChild] private Overlay notifications_overlay;
+ [GtkChild] private unowned Overlay notifications_overlay;
private bool notifications_revealer_created = false;
private NotificationsRevealer notifications_revealer;
diff --git a/editor/base-window.vala b/editor/base-window.vala
index 25ec30ae..8daf6f98 100644
--- a/editor/base-window.vala
+++ b/editor/base-window.vala
@@ -72,7 +72,7 @@ private class BaseWindow : AdaptativeWindow, AdaptativeWidget
* * main grid
\*/
- [GtkChild] private Grid main_grid;
+ [GtkChild] private unowned Grid main_grid;
protected void add_to_main_grid (Widget widget)
{
diff --git a/editor/bookmarks-controller.vala b/editor/bookmarks-controller.vala
index 5455df32..53dc4f87 100644
--- a/editor/bookmarks-controller.vala
+++ b/editor/bookmarks-controller.vala
@@ -20,17 +20,17 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/bookmarks-controller.ui")]
private class BookmarksController : Grid
{
- [GtkChild] private Image big_rows_icon;
- [GtkChild] private Image small_rows_icon;
+ [GtkChild] private unowned Image big_rows_icon;
+ [GtkChild] private unowned Image small_rows_icon;
- [GtkChild] private Button rows_size_button;
+ [GtkChild] private unowned Button rows_size_button;
[CCode (notify = false)] public bool show_rows_size_button { private get; construct; default = false; }
- [GtkChild] private Button trash_bookmark_button;
- [GtkChild] private Button move_top_button;
- [GtkChild] private Button move_up_button;
- [GtkChild] private Button move_down_button;
- [GtkChild] private Button move_bottom_button;
+ [GtkChild] private unowned Button trash_bookmark_button;
+ [GtkChild] private unowned Button move_top_button;
+ [GtkChild] private unowned Button move_up_button;
+ [GtkChild] private unowned Button move_down_button;
+ [GtkChild] private unowned Button move_bottom_button;
[CCode (notify = false)] public string controller_action_prefix
{
construct
diff --git a/editor/bookmarks-list.vala b/editor/bookmarks-list.vala
index c9280d59..6ba01696 100644
--- a/editor/bookmarks-list.vala
+++ b/editor/bookmarks-list.vala
@@ -508,7 +508,7 @@ private class BookmarksList : OverlayedList
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/bookmark.ui")]
private class Bookmark : OverlayedListRow
{
- [GtkChild] private Label bookmark_label;
+ [GtkChild] private unowned Label bookmark_label;
[CCode (notify = false)] public string bookmark_name { internal get; internal construct; }
diff --git a/editor/bookmarks.vala b/editor/bookmarks.vala
index d8cea7cc..5c0c4133 100644
--- a/editor/bookmarks.vala
+++ b/editor/bookmarks.vala
@@ -32,13 +32,13 @@ internal enum BookmarkIcon {
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/bookmarks.ui")]
private class Bookmarks : MenuButton
{
- [GtkChild] private Image bookmarks_icon;
- [GtkChild] private Popover bookmarks_popover;
- [GtkChild] private Stack edit_mode_stack;
- [GtkChild] private BookmarksList bookmarks_list;
- [GtkChild] private Switch bookmarked_switch;
- [GtkChild] private Label switch_label;
- [GtkChild] private BookmarksController bookmarks_controller;
+ [GtkChild] private unowned Image bookmarks_icon;
+ [GtkChild] private unowned Popover bookmarks_popover;
+ [GtkChild] private unowned Stack edit_mode_stack;
+ [GtkChild] private unowned BookmarksList bookmarks_list;
+ [GtkChild] private unowned Switch bookmarked_switch;
+ [GtkChild] private unowned Label switch_label;
+ [GtkChild] private unowned BookmarksController bookmarks_controller;
private string current_path = "/";
private ViewType current_type = ViewType.FOLDER;
diff --git a/editor/browser-infobar.vala b/editor/browser-infobar.vala
index a684c38e..cbb51d05 100644
--- a/editor/browser-infobar.vala
+++ b/editor/browser-infobar.vala
@@ -20,7 +20,7 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/browser-infobar.ui")]
private class BrowserInfoBar : Revealer
{
- [GtkChild] private Stack content;
+ [GtkChild] private unowned Stack content;
internal void add_label (string name, string text_label, string? button_label = null, string
button_action = "")
{
diff --git a/editor/browser-stack.vala b/editor/browser-stack.vala
index b630a737..38c55e3e 100644
--- a/editor/browser-stack.vala
+++ b/editor/browser-stack.vala
@@ -20,10 +20,10 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/browser-stack.ui")]
private class BrowserStack : Grid, AdaptativeWidget, BrowserContent
{
- [GtkChild] private Stack stack;
- [GtkChild] private RegistryView folder_view;
- [GtkChild] private RegistryInfo object_view;
- [GtkChild] private RegistrySearch search_view;
+ [GtkChild] private unowned Stack stack;
+ [GtkChild] private unowned RegistryView folder_view;
+ [GtkChild] private unowned RegistryInfo object_view;
+ [GtkChild] private unowned RegistrySearch search_view;
[CCode (notify = false)] internal ViewType current_view { internal get; protected set; default =
ViewType.FOLDER; }
diff --git a/editor/delayed-setting-view.vala b/editor/delayed-setting-view.vala
index b1f774ca..87ee607d 100644
--- a/editor/delayed-setting-view.vala
+++ b/editor/delayed-setting-view.vala
@@ -20,12 +20,12 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/delayed-setting-view.ui")]
private class DelayedSettingView : OverlayedListRow
{
- [GtkChild] private Label key_name_label;
- [GtkChild] private Label key_value_label;
- [GtkChild] private Label key_value_default;
- [GtkChild] private Label planned_value_label;
- [GtkChild] private Label planned_value_default;
- [GtkChild] private Button cancel_change_button;
+ [GtkChild] private unowned Label key_name_label;
+ [GtkChild] private unowned Label key_value_label;
+ [GtkChild] private unowned Label key_value_default;
+ [GtkChild] private unowned Label planned_value_label;
+ [GtkChild] private unowned Label planned_value_default;
+ [GtkChild] private unowned Button cancel_change_button;
[CCode (notify = false)] public string full_name { internal get; internal construct; }
[CCode (notify = false)] public uint16 context_id { internal get; internal construct; }
diff --git a/editor/key-list-box-row.vala b/editor/key-list-box-row.vala
index e56fb417..d195c348 100644
--- a/editor/key-list-box-row.vala
+++ b/editor/key-list-box-row.vala
@@ -109,7 +109,7 @@ private abstract class ClickableListBoxRow : EventBox
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/return-list-box-row.ui")]
private class ReturnListBoxRow : ClickableListBoxRow
{
- [GtkChild] private Label folder_name_label;
+ [GtkChild] private unowned Label folder_name_label;
internal ReturnListBoxRow (string _full_name, uint16 _context_id)
{
@@ -122,7 +122,7 @@ private class ReturnListBoxRow : ClickableListBoxRow
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/folder-list-box-row.ui")]
private class FolderListBoxRow : ClickableListBoxRow
{
- [GtkChild] private Label folder_name_label;
+ [GtkChild] private unowned Label folder_name_label;
[CCode (notify = false)] public bool path_search { internal get; internal construct; }
@@ -138,7 +138,7 @@ private class FilterListBoxRow : ClickableListBoxRow
{
public bool is_local_search { internal get; protected construct; }
- [GtkChild] private Label folder_name_label;
+ [GtkChild] private unowned Label folder_name_label;
internal FilterListBoxRow (string name, string path)
{
@@ -161,7 +161,7 @@ private class FilterListBoxRow : ClickableListBoxRow
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/search-list-box-row.ui")]
private class SearchListBoxRow : ClickableListBoxRow
{
- [GtkChild] private Label search_label;
+ [GtkChild] private unowned Label search_label;
internal SearchListBoxRow (string search)
{
@@ -173,11 +173,11 @@ private class SearchListBoxRow : ClickableListBoxRow
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/key-list-box-row.ui")]
private class KeyListBoxRow : ClickableListBoxRow, AdaptativeWidget
{
- [GtkChild] private Grid key_name_and_value_grid;
- [GtkChild] private Label key_name_label;
- [GtkChild] private Label key_type_label;
- [GtkChild] private Label key_value_label;
- [GtkChild] private Label key_info_label;
+ [GtkChild] private unowned Grid key_name_and_value_grid;
+ [GtkChild] private unowned Label key_name_label;
+ [GtkChild] private unowned Label key_type_label;
+ [GtkChild] private unowned Label key_value_label;
+ [GtkChild] private unowned Label key_info_label;
private Switch? boolean_switch = null;
[CCode (notify = false)] public string key_name { internal get; internal construct; }
diff --git a/editor/large-pathbar.vala b/editor/large-pathbar.vala
index 312af6cb..565f09b7 100644
--- a/editor/large-pathbar.vala
+++ b/editor/large-pathbar.vala
@@ -20,7 +20,7 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/large-pathbar.ui")]
private class LargePathbar : Box, Pathbar
{
- [GtkChild] private LargePathbarItem root_button;
+ [GtkChild] private unowned LargePathbarItem root_button;
private LargePathbarItem active_button;
private string complete_path = "";
@@ -314,7 +314,7 @@ private class LargePathbarItem : Button
[CCode (notify = false)] public string text_string { internal get; internal construct; }
[CCode (notify = false)] public bool has_config_menu { private get; internal construct; }
- [GtkChild] private Label text_label;
+ [GtkChild] private unowned Label text_label;
private Popover? popover = null;
internal enum CursorType {
diff --git a/editor/modifications-revealer.vala b/editor/modifications-revealer.vala
index 1ab64841..f47cc636 100644
--- a/editor/modifications-revealer.vala
+++ b/editor/modifications-revealer.vala
@@ -63,11 +63,11 @@ private class ModificationsRevealer : Revealer, AdaptativeWidget
}
}
- [GtkChild] private Label label;
- [GtkChild] private ModelButton apply_button;
- [GtkChild] private MenuButton delayed_list_button;
- [GtkChild] private Popover delayed_settings_list_popover;
- [GtkChild] private ModificationsList modifications_list;
+ [GtkChild] private unowned Label label;
+ [GtkChild] private unowned ModelButton apply_button;
+ [GtkChild] private unowned MenuButton delayed_list_button;
+ [GtkChild] private unowned Popover delayed_settings_list_popover;
+ [GtkChild] private unowned ModificationsList modifications_list;
private ThemedIcon apply_button_icon = new ThemedIcon.from_names ({"object-select-symbolic"});
diff --git a/editor/notifications-revealer.vala b/editor/notifications-revealer.vala
index 4f8ce961..55bf61a0 100644
--- a/editor/notifications-revealer.vala
+++ b/editor/notifications-revealer.vala
@@ -20,7 +20,7 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/notifications-revealer.ui")]
private class NotificationsRevealer : Revealer, AdaptativeWidget
{
- [GtkChild] private Label notification_label;
+ [GtkChild] private unowned Label notification_label;
construct
{
diff --git a/editor/overlayed-list.vala b/editor/overlayed-list.vala
index bcdfc3a0..1558a61b 100644
--- a/editor/overlayed-list.vala
+++ b/editor/overlayed-list.vala
@@ -20,12 +20,12 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/overlayed-list.ui")]
private abstract class OverlayedList : Overlay, AdaptativeWidget
{
- [GtkChild] protected ListBox main_list_box;
+ [GtkChild] protected unowned ListBox main_list_box;
private StyleContext main_list_box_context;
protected GLib.ListStore main_list_store = new GLib.ListStore (typeof (Widget));
- [GtkChild] private ScrolledWindow scrolled;
- [GtkChild] private Box edit_mode_box;
+ [GtkChild] private unowned ScrolledWindow scrolled;
+ [GtkChild] private unowned Box edit_mode_box;
/*\
* * differed construct
@@ -45,8 +45,8 @@ private abstract class OverlayedList : Overlay, AdaptativeWidget
}
- [GtkChild] private ModelButton enter_edit_mode_button;
- [GtkChild] private ModelButton leave_edit_mode_button;
+ [GtkChild] private unowned ModelButton enter_edit_mode_button;
+ [GtkChild] private unowned ModelButton leave_edit_mode_button;
[CCode (notify = false)] public string edit_mode_action_prefix
{
construct
diff --git a/editor/pathentry.vala b/editor/pathentry.vala
index 5c7efc56..ae7c2b01 100644
--- a/editor/pathentry.vala
+++ b/editor/pathentry.vala
@@ -54,11 +54,11 @@ private class BrowserEntry : SearchEntry
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/pathentry.ui")]
private class PathEntry : Box, AdaptativeWidget
{
- [GtkChild] private Button hide_search_button;
- [GtkChild] private Button reload_search_button;
+ [GtkChild] private unowned Button hide_search_button;
+ [GtkChild] private unowned Button reload_search_button;
- [GtkChild] private BrowserEntry search_entry;
- [GtkChild] private Button search_action_button;
+ [GtkChild] private unowned BrowserEntry search_entry;
+ [GtkChild] private unowned Button search_action_button;
private string current_path = "";
diff --git a/editor/pathwidget.vala b/editor/pathwidget.vala
index c28051ca..20ac309c 100644
--- a/editor/pathwidget.vala
+++ b/editor/pathwidget.vala
@@ -20,15 +20,15 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/pathwidget.ui")]
private class PathWidget : Box, AdaptativeWidget
{
- [GtkChild] private ModelButton search_toggle; // most window size button
- [GtkChild] private ModelButton search_button; // extra-small-window only
- [GtkChild] private Stack pathwidget_stack;
- [GtkChild] private Grid pathbar_grid;
- [GtkChild] private AdaptativePathbar pathbar;
- [GtkChild] private PathEntry searchentry;
-
- [GtkChild] private Revealer parent_revealer;
- [GtkChild] private ModelButton parent_button;
+ [GtkChild] private unowned ModelButton search_toggle; // most window size button
+ [GtkChild] private unowned ModelButton search_button; // extra-small-window only
+ [GtkChild] private unowned Stack pathwidget_stack;
+ [GtkChild] private unowned Grid pathbar_grid;
+ [GtkChild] private unowned AdaptativePathbar pathbar;
+ [GtkChild] private unowned PathEntry searchentry;
+
+ [GtkChild] private unowned Revealer parent_revealer;
+ [GtkChild] private unowned ModelButton parent_button;
private ThemedIcon search_icon = new ThemedIcon.from_names ({"edit-find-symbolic"});
private ThemedIcon parent_icon = new ThemedIcon.from_names ({"go-up-symbolic"});
diff --git a/editor/registry-info.vala b/editor/registry-info.vala
index c9ce56a1..d4088f75 100644
--- a/editor/registry-info.vala
+++ b/editor/registry-info.vala
@@ -20,15 +20,15 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/registry-info.ui")]
private class RegistryInfo : Grid, BrowsableView
{
- [GtkChild] private Revealer conflicting_key_warning_revealer;
- [GtkChild] private Revealer hard_conflicting_key_error_revealer;
- [GtkChild] private Revealer no_schema_warning;
- [GtkChild] private Revealer one_choice_warning_revealer;
- [GtkChild] private Label one_choice_enum_warning;
- [GtkChild] private Label one_choice_integer_warning;
- [GtkChild] private Label one_choice_tuple_warning;
- [GtkChild] private ListBox properties_list_box;
- [GtkChild] private Button erase_button;
+ [GtkChild] private unowned Revealer conflicting_key_warning_revealer;
+ [GtkChild] private unowned Revealer hard_conflicting_key_error_revealer;
+ [GtkChild] private unowned Revealer no_schema_warning;
+ [GtkChild] private unowned Revealer one_choice_warning_revealer;
+ [GtkChild] private unowned Label one_choice_enum_warning;
+ [GtkChild] private unowned Label one_choice_integer_warning;
+ [GtkChild] private unowned Label one_choice_tuple_warning;
+ [GtkChild] private unowned ListBox properties_list_box;
+ [GtkChild] private unowned Button erase_button;
private Label current_value_label;
@@ -684,8 +684,8 @@ private class RegistryInfo : Grid, BrowsableView
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/property-row.ui")]
private class PropertyRow : ListBoxRowWrapper
{
- [GtkChild] private Overlay overlay;
- [GtkChild] private Label name_label;
+ [GtkChild] private unowned Overlay overlay;
+ [GtkChild] private unowned Label name_label;
private Widget? value_widget = null;
diff --git a/editor/registry-list.vala b/editor/registry-list.vala
index 54aa6fa6..bd93eb35 100644
--- a/editor/registry-list.vala
+++ b/editor/registry-list.vala
@@ -20,8 +20,8 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/registry-list.ui")]
private abstract class RegistryList : Grid, BrowsableView, AdaptativeWidget
{
- [GtkChild] protected ListBox key_list_box;
- [GtkChild] private ScrolledWindow scrolled;
+ [GtkChild] protected unowned ListBox key_list_box;
+ [GtkChild] private unowned ScrolledWindow scrolled;
private Adjustment adjustment;
[CCode (notify = false)] protected bool search_mode { private get; protected set; }
@@ -34,7 +34,7 @@ private abstract class RegistryList : Grid, BrowsableView, AdaptativeWidget
[CCode (notify = false)] internal ModificationsHandler modifications_handler { protected get; set; }
- [GtkChild] private RegistryPlaceholder placeholder;
+ [GtkChild] private unowned RegistryPlaceholder placeholder;
[CCode (notify = false)] public abstract string placeholder_label { protected get; }
construct
diff --git a/editor/registry-placeholder.vala b/editor/registry-placeholder.vala
index f2a0d4be..2e68d72b 100644
--- a/editor/registry-placeholder.vala
+++ b/editor/registry-placeholder.vala
@@ -20,8 +20,8 @@ using Gtk;
[GtkTemplate (ui = "/ca/desrt/dconf-editor/ui/registry-placeholder.ui")]
private class RegistryPlaceholder : Grid
{
- [GtkChild] private Label placeholder_label;
- [GtkChild] private Image placeholder_image;
+ [GtkChild] private unowned Label placeholder_label;
+ [GtkChild] private unowned Image placeholder_image;
[CCode (notify = false)] public string label { internal construct set { placeholder_label.label =
value; }}
[CCode (notify = false)] public string icon_name { private get; internal construct; }
diff --git a/editor/short-pathbar.vala b/editor/short-pathbar.vala
index d415baa1..801dcc9d 100644
--- a/editor/short-pathbar.vala
+++ b/editor/short-pathbar.vala
@@ -37,8 +37,8 @@ private class ShortPathbar : Grid, Pathbar // TODO make MenuButton?
_complete_path = complete_path;
}
- [GtkChild] private MenuButton menu_button;
- [GtkChild] private Label view_label;
+ [GtkChild] private unowned MenuButton menu_button;
+ [GtkChild] private unowned Label view_label;
internal ShortPathbar (string complete_path_or_empty, ViewType type, string path)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
