[simple-scan/ricotz/vala] Reference of [GtkChild] fields is handled by GtkBuilder, type must be unowned
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [simple-scan/ricotz/vala] Reference of [GtkChild] fields is handled by GtkBuilder, type must be unowned
- Date: Wed, 17 Mar 2021 11:15:59 +0000 (UTC)
commit 8c2f62073ae0cd9446f9e102013f890ebbc9a093
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Wed Mar 17 12:15:08 2021 +0100
Reference of [GtkChild] fields is handled by GtkBuilder, type must be unowned
src/app-window.vala | 70 ++++++++++++++++++++++-----------------------
src/authorize-dialog.vala | 6 ++--
src/preferences-dialog.vala | 36 +++++++++++------------
3 files changed, 56 insertions(+), 56 deletions(-)
---
diff --git a/src/app-window.vala b/src/app-window.vala
index e718a249..c4d0cb87 100644
--- a/src/app-window.vala
+++ b/src/app-window.vala
@@ -48,79 +48,79 @@ public class AppWindow : Hdy.ApplicationWindow
private bool user_selected_device;
[GtkChild]
- private Hdy.HeaderBar header_bar;
+ private unowned Hdy.HeaderBar header_bar;
[GtkChild]
- private Gtk.Menu page_menu;
+ private unowned Gtk.Menu page_menu;
[GtkChild]
- private Gtk.Stack stack;
+ private unowned Gtk.Stack stack;
[GtkChild]
- private Hdy.StatusPage status_page;
+ private unowned Hdy.StatusPage status_page;
[GtkChild]
- private Gtk.Label status_secondary_label;
+ private unowned Gtk.Label status_secondary_label;
[GtkChild]
- private Gtk.ListStore device_model;
+ private unowned Gtk.ListStore device_model;
[GtkChild]
- private Gtk.Box device_buttons_box;
+ private unowned Gtk.Box device_buttons_box;
[GtkChild]
- private Gtk.ComboBox device_combo;
+ private unowned Gtk.ComboBox device_combo;
[GtkChild]
- private Gtk.Box main_vbox;
+ private unowned Gtk.Box main_vbox;
[GtkChild]
- private Gtk.RadioMenuItem custom_crop_menuitem;
+ private unowned Gtk.RadioMenuItem custom_crop_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem a3_menuitem;
+ private unowned Gtk.RadioMenuItem a3_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem a4_menuitem;
+ private unowned Gtk.RadioMenuItem a4_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem a5_menuitem;
+ private unowned Gtk.RadioMenuItem a5_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem a6_menuitem;
+ private unowned Gtk.RadioMenuItem a6_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem letter_menuitem;
+ private unowned Gtk.RadioMenuItem letter_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem legal_menuitem;
+ private unowned Gtk.RadioMenuItem legal_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem four_by_six_menuitem;
+ private unowned Gtk.RadioMenuItem four_by_six_menuitem;
[GtkChild]
- private Gtk.RadioMenuItem no_crop_menuitem;
+ private unowned Gtk.RadioMenuItem no_crop_menuitem;
[GtkChild]
- private Gtk.MenuItem page_move_left_menuitem;
+ private unowned Gtk.MenuItem page_move_left_menuitem;
[GtkChild]
- private Gtk.MenuItem page_move_right_menuitem;
+ private unowned Gtk.MenuItem page_move_right_menuitem;
[GtkChild]
- private Gtk.MenuItem page_delete_menuitem;
+ private unowned Gtk.MenuItem page_delete_menuitem;
[GtkChild]
- private Gtk.MenuItem crop_rotate_menuitem;
+ private unowned Gtk.MenuItem crop_rotate_menuitem;
[GtkChild]
- private Gtk.MenuItem copy_to_clipboard_menuitem;
+ private unowned Gtk.MenuItem copy_to_clipboard_menuitem;
[GtkChild]
- private Gtk.Button save_button;
+ private unowned Gtk.Button save_button;
[GtkChild]
- private Gtk.Button stop_button;
+ private unowned Gtk.Button stop_button;
[GtkChild]
- private Gtk.Button scan_button;
+ private unowned Gtk.Button scan_button;
[GtkChild]
- private Gtk.ActionBar action_bar;
+ private unowned Gtk.ActionBar action_bar;
private Gtk.ToggleButton crop_button;
private Gtk.Button delete_button;
[GtkChild]
- private Gtk.Image scan_options_image;
+ private unowned Gtk.Image scan_options_image;
[GtkChild]
- private Gtk.Image scan_hint_image;
+ private unowned Gtk.Image scan_hint_image;
[GtkChild]
- private Gtk.RadioButton scan_single_radio;
+ private unowned Gtk.RadioButton scan_single_radio;
[GtkChild]
- private Gtk.RadioButton scan_adf_radio;
+ private unowned Gtk.RadioButton scan_adf_radio;
[GtkChild]
- private Gtk.RadioButton scan_batch_radio;
+ private unowned Gtk.RadioButton scan_batch_radio;
[GtkChild]
- private Gtk.RadioButton text_radio;
+ private unowned Gtk.RadioButton text_radio;
[GtkChild]
- private Gtk.RadioButton photo_radio;
+ private unowned Gtk.RadioButton photo_radio;
[GtkChild]
- private Gtk.MenuButton menu_button;
+ private unowned Gtk.MenuButton menu_button;
private bool have_devices = false;
private string? missing_driver = null;
diff --git a/src/authorize-dialog.vala b/src/authorize-dialog.vala
index 3b61e00f..7cb2a661 100644
--- a/src/authorize-dialog.vala
+++ b/src/authorize-dialog.vala
@@ -14,11 +14,11 @@
private class AuthorizeDialog : Gtk.Dialog
{
[GtkChild]
- private Gtk.Label authorize_label;
+ private unowned Gtk.Label authorize_label;
[GtkChild]
- private Gtk.Entry username_entry;
+ private unowned Gtk.Entry username_entry;
[GtkChild]
- private Gtk.Entry password_entry;
+ private unowned Gtk.Entry password_entry;
public AuthorizeDialog (string title)
{
diff --git a/src/preferences-dialog.vala b/src/preferences-dialog.vala
index 374fe7c3..e10e1534 100644
--- a/src/preferences-dialog.vala
+++ b/src/preferences-dialog.vala
@@ -16,41 +16,41 @@ private class PreferencesDialog : Hdy.PreferencesWindow
private Settings settings;
[GtkChild]
- private Gtk.ComboBox text_dpi_combo;
+ private unowned Gtk.ComboBox text_dpi_combo;
[GtkChild]
- private Gtk.ComboBox photo_dpi_combo;
+ private unowned Gtk.ComboBox photo_dpi_combo;
[GtkChild]
- private Gtk.ComboBox paper_size_combo;
+ private unowned Gtk.ComboBox paper_size_combo;
[GtkChild]
- private Gtk.Scale brightness_scale;
+ private unowned Gtk.Scale brightness_scale;
[GtkChild]
- private Gtk.Scale contrast_scale;
+ private unowned Gtk.Scale contrast_scale;
[GtkChild]
- private Gtk.RadioButton page_delay_0s_button;
+ private unowned Gtk.RadioButton page_delay_0s_button;
[GtkChild]
- private Gtk.RadioButton page_delay_3s_button;
+ private unowned Gtk.RadioButton page_delay_3s_button;
[GtkChild]
- private Gtk.RadioButton page_delay_6s_button;
+ private unowned Gtk.RadioButton page_delay_6s_button;
[GtkChild]
- private Gtk.RadioButton page_delay_10s_button;
+ private unowned Gtk.RadioButton page_delay_10s_button;
[GtkChild]
- private Gtk.RadioButton page_delay_15s_button;
+ private unowned Gtk.RadioButton page_delay_15s_button;
[GtkChild]
- private Gtk.ListStore text_dpi_model;
+ private unowned Gtk.ListStore text_dpi_model;
[GtkChild]
- private Gtk.ListStore photo_dpi_model;
+ private unowned Gtk.ListStore photo_dpi_model;
[GtkChild]
- private Gtk.RadioButton front_side_button;
+ private unowned Gtk.RadioButton front_side_button;
[GtkChild]
- private Gtk.RadioButton back_side_button;
+ private unowned Gtk.RadioButton back_side_button;
[GtkChild]
- private Gtk.RadioButton both_side_button;
+ private unowned Gtk.RadioButton both_side_button;
[GtkChild]
- private Gtk.ListStore paper_size_model;
+ private unowned Gtk.ListStore paper_size_model;
[GtkChild]
- private Gtk.Adjustment brightness_adjustment;
+ private unowned Gtk.Adjustment brightness_adjustment;
[GtkChild]
- private Gtk.Adjustment contrast_adjustment;
+ private unowned Gtk.Adjustment contrast_adjustment;
public PreferencesDialog (Settings settings)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]