[gnome-flashback] notifications: remove unused nd_notification_get_is_queued
- From: Alberts Muktupāvels <muktupavels src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-flashback] notifications: remove unused nd_notification_get_is_queued
- Date: Tue, 16 Mar 2021 20:43:13 +0000 (UTC)
commit 501e2d5a02734d1aa5281baa1501ee60d1182bed
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date: Tue Mar 16 19:09:04 2021 +0200
notifications: remove unused nd_notification_get_is_queued
This will remove false positive defect about use after free.
Coverity CID: #1502693
gnome-flashback/libnotifications/nd-notification.c | 11 -----------
gnome-flashback/libnotifications/nd-notification.h | 1 -
2 files changed, 12 deletions(-)
---
diff --git a/gnome-flashback/libnotifications/nd-notification.c
b/gnome-flashback/libnotifications/nd-notification.c
index 77b5255..a12c12d 100644
--- a/gnome-flashback/libnotifications/nd-notification.c
+++ b/gnome-flashback/libnotifications/nd-notification.c
@@ -38,7 +38,6 @@ struct _NdNotification {
GObject parent;
gboolean is_queued;
- gboolean is_closed;
gint64 update_time;
@@ -447,14 +446,6 @@ nd_notification_get_is_queued (NdNotification *notification)
return notification->is_queued;
}
-gboolean
-nd_notification_get_is_closed (NdNotification *notification)
-{
- g_return_val_if_fail (ND_IS_NOTIFICATION (notification), FALSE);
-
- return notification->is_closed;
-}
-
gboolean
nd_notification_get_is_transient (NdNotification *notification)
{
@@ -536,8 +527,6 @@ nd_notification_close (NdNotification *notification,
g_object_ref (notification);
g_signal_emit (notification, signals[CLOSED], 0, reason);
g_object_unref (notification);
-
- notification->is_closed = TRUE;
}
void
diff --git a/gnome-flashback/libnotifications/nd-notification.h
b/gnome-flashback/libnotifications/nd-notification.h
index 32382f7..418a657 100644
--- a/gnome-flashback/libnotifications/nd-notification.h
+++ b/gnome-flashback/libnotifications/nd-notification.h
@@ -58,7 +58,6 @@ void nd_notification_set_is_queued (NdNotification *notif
gboolean is_queued);
gboolean nd_notification_get_is_queued (NdNotification *notification);
-gboolean nd_notification_get_is_closed (NdNotification *notification);
gint64 nd_notification_get_update_time (NdNotification *notification);
guint nd_notification_get_id (NdNotification *notification);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]