[gimp] plug-ins: fix several memory leaks in metadata-editor.



commit 184b803811edfb5a8c75a9fa5c99718fb544ecb0
Author: Jacob Boerema <jgboerema gmail com>
Date:   Sun Mar 14 18:32:09 2021 -0400

    plug-ins: fix several memory leaks in metadata-editor.

 plug-ins/metadata/metadata-editor.c | 7 +++++++
 1 file changed, 7 insertions(+)
---
diff --git a/plug-ins/metadata/metadata-editor.c b/plug-ins/metadata/metadata-editor.c
index 9a204e0f1c..f1dbd95948 100644
--- a/plug-ins/metadata/metadata-editor.c
+++ b/plug-ins/metadata/metadata-editor.c
@@ -1981,6 +1981,7 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
           gchar *value_utf;
 
           value_utf = clean_xmp_string (value);
+          g_free (value);
 
           if (! strcmp ("single", imageSupplierInfoTags[i].mode))
             {
@@ -1993,6 +1994,7 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
               buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (widget));
               gtk_text_buffer_set_text (buffer, value_utf, -1);
             }
+          g_free (value_utf);
         }
     }
 
@@ -2011,11 +2013,13 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
           gchar *value_utf;
 
           value_utf = clean_xmp_string (value);
+          g_free (value);
 
           if (! strcmp ("single", locationCreationInfoTags[i].mode))
             {
               gtk_entry_set_text (GTK_ENTRY (widget), value_utf);
             }
+          g_free (value_utf);
         }
     }
 
@@ -2035,6 +2039,7 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
           gchar *value_utf;
 
           value_utf = clean_xmp_string (value);
+          g_free (value);
 
           if (! strcmp ("single", creatorContactInfoTags[i].mode))
             {
@@ -2046,6 +2051,7 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
               buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (widget));
               gtk_text_buffer_set_text (buffer, value_utf, -1);
             }
+          g_free (value_utf);
         }
     }
 
@@ -3609,6 +3615,7 @@ metadata_dialog_editor_set_metadata (GExiv2Metadata *metadata,
                   gtk_combo_box_set_active (GTK_COMBO_BOX (widget), data);
                 }
             }
+          g_free (value);
         }
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]