[msitools: 3/6] libmsi: fix property conversion




commit 08fb1456d13f582d280adda491880d4ee9c63d3a
Author: Marc-André Lureau <marcandre lureau redhat com>
Date:   Tue Mar 16 13:09:16 2021 +0400

    libmsi: fix property conversion
    
    Fixes #35 "Invalid pointer dereference in print_suminfo"
    
    Signed-off-by: Marc-André Lureau <marcandre lureau redhat com>

 libmsi/libmsi-summary-info.c | 5 +++++
 1 file changed, 5 insertions(+)
---
diff --git a/libmsi/libmsi-summary-info.c b/libmsi/libmsi-summary-info.c
index 2ecc4f8..2e7f513 100644
--- a/libmsi/libmsi-summary-info.c
+++ b/libmsi/libmsi-summary-info.c
@@ -401,7 +401,12 @@ static void read_properties_from_data( LibmsiOLEVariant *prop, const uint8_t *da
                 property->intval = atoi( str );
             } else if( type == OLEVT_FILETIME) {
                 parse_filetime( str, &property->filetime );
+            } else {
+                g_critical("invalid type, it can't be converted\n");
+                msi_free(str);
+                break;
             }
+            proptype = type;
             msi_free (str);
         }
         else


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]