[shotwell/wip/vapi-fixes: 1/3] Sprinkle some defaults to switch/case




commit cfa0d782e5b579736c51efe02eb3527506801e8e
Author: Jens Georg <mail jensge org>
Date:   Sat Mar 13 22:28:41 2021 +0100

    Sprinkle some defaults to switch/case
    
    There were some unhandled and thus ignored cases that maked recentish
    vala print a warning

 src/photos/PhotoMetadata.vala | 6 ++++++
 src/util/string.vala          | 2 ++
 2 files changed, 8 insertions(+)
---
diff --git a/src/photos/PhotoMetadata.vala b/src/photos/PhotoMetadata.vala
index 70a83e3f..9dcdf1b8 100644
--- a/src/photos/PhotoMetadata.vala
+++ b/src/photos/PhotoMetadata.vala
@@ -390,6 +390,9 @@ public class PhotoMetadata : MediaMetadata {
             case MetadataDomain.IPTC:
                 tags = exiv2.get_iptc_tags();
             break;
+            default:
+            // Just ignore any other unknown tags
+            break;
         }
         
         if (tags == null || tags.length == 0)
@@ -793,6 +796,9 @@ public class PhotoMetadata : MediaMetadata {
             case MetadataDomain.IPTC:
                 exiv2.clear_iptc();
             break;
+            default:
+                // Just ignore any unknown tags
+            break;
         }
     }
     
diff --git a/src/util/string.vala b/src/util/string.vala
index 0ff60f05..44bd6174 100644
--- a/src/util/string.vala
+++ b/src/util/string.vala
@@ -237,6 +237,8 @@ public string remove_diacritics(string istring) {
             case UnicodeType.ENCLOSING_MARK:
             // Ignore those
                 continue;
+            default:
+                break;
         }
         builder.append_unichar(ch);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]