[librsvg: 6/8] Remove unused method FilterEffect::is_affected_by_color_interpolation_filters




commit 80e34768e6dea21770d9da84b180e02a45ef10d9
Author: Federico Mena Quintero <federico gnome org>
Date:   Wed Mar 10 20:54:53 2021 -0600

    Remove unused method FilterEffect::is_affected_by_color_interpolation_filters
    
    Now that trait is empty!

 src/filters/blend.rs              | 7 +------
 src/filters/color_matrix.rs       | 7 +------
 src/filters/component_transfer.rs | 6 +-----
 src/filters/composite.rs          | 7 +------
 src/filters/convolve_matrix.rs    | 7 +------
 src/filters/displacement_map.rs   | 9 +--------
 src/filters/flood.rs              | 7 +------
 src/filters/gaussian_blur.rs      | 7 +------
 src/filters/image.rs              | 7 +------
 src/filters/lighting.rs           | 7 +------
 src/filters/merge.rs              | 7 +------
 src/filters/mod.rs                | 9 +--------
 src/filters/morphology.rs         | 7 +------
 src/filters/offset.rs             | 7 +------
 src/filters/tile.rs               | 7 +------
 src/filters/turbulence.rs         | 7 +------
 16 files changed, 16 insertions(+), 99 deletions(-)
---
diff --git a/src/filters/blend.rs b/src/filters/blend.rs
index 8728a5d6..47e13a17 100755
--- a/src/filters/blend.rs
+++ b/src/filters/blend.rs
@@ -106,12 +106,7 @@ impl FilterRender for FeBlend {
     }
 }
 
-impl FilterEffect for FeBlend {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeBlend {}
 
 impl Parse for Mode {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/color_matrix.rs b/src/filters/color_matrix.rs
index 31ecdf2e..87376fb6 100644
--- a/src/filters/color_matrix.rs
+++ b/src/filters/color_matrix.rs
@@ -207,12 +207,7 @@ impl FilterRender for FeColorMatrix {
     }
 }
 
-impl FilterEffect for FeColorMatrix {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeColorMatrix {}
 
 impl Parse for OperationType {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/component_transfer.rs b/src/filters/component_transfer.rs
index 62923bd7..80576939 100644
--- a/src/filters/component_transfer.rs
+++ b/src/filters/component_transfer.rs
@@ -370,11 +370,7 @@ impl FilterRender for FeComponentTransfer {
     }
 }
 
-impl FilterEffect for FeComponentTransfer {
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeComponentTransfer {}
 
 /// Takes a feComponentTransfer and walks its children to produce the feFuncX arguments.
 fn get_parameters(node: &Node) -> Result<Functions, FilterError> {
diff --git a/src/filters/composite.rs b/src/filters/composite.rs
index ae92b180..2aff190f 100644
--- a/src/filters/composite.rs
+++ b/src/filters/composite.rs
@@ -118,12 +118,7 @@ impl FilterRender for FeComposite {
     }
 }
 
-impl FilterEffect for FeComposite {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeComposite {}
 
 impl Parse for Operator {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/convolve_matrix.rs b/src/filters/convolve_matrix.rs
index 4d6723b1..8d5ec68a 100644
--- a/src/filters/convolve_matrix.rs
+++ b/src/filters/convolve_matrix.rs
@@ -288,12 +288,7 @@ impl FilterRender for FeConvolveMatrix {
     }
 }
 
-impl FilterEffect for FeConvolveMatrix {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeConvolveMatrix {}
 
 impl Parse for EdgeMode {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/displacement_map.rs b/src/filters/displacement_map.rs
index 42d00e55..92570406 100644
--- a/src/filters/displacement_map.rs
+++ b/src/filters/displacement_map.rs
@@ -156,14 +156,7 @@ impl FilterRender for FeDisplacementMap {
     }
 }
 
-impl FilterEffect for FeDisplacementMap {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        // Performance TODO: this converts in back and forth to linear RGB while technically it's
-        // only needed for in2.
-        true
-    }
-}
+impl FilterEffect for FeDisplacementMap {}
 
 impl Parse for ColorChannel {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/flood.rs b/src/filters/flood.rs
index e461e0c6..7d5a54c8 100644
--- a/src/filters/flood.rs
+++ b/src/filters/flood.rs
@@ -56,9 +56,4 @@ impl FilterRender for FeFlood {
     }
 }
 
-impl FilterEffect for FeFlood {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        false
-    }
-}
+impl FilterEffect for FeFlood {}
diff --git a/src/filters/gaussian_blur.rs b/src/filters/gaussian_blur.rs
index a752255c..834087ab 100644
--- a/src/filters/gaussian_blur.rs
+++ b/src/filters/gaussian_blur.rs
@@ -247,9 +247,4 @@ impl FilterRender for FeGaussianBlur {
     }
 }
 
-impl FilterEffect for FeGaussianBlur {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeGaussianBlur {}
diff --git a/src/filters/image.rs b/src/filters/image.rs
index e328ae98..c0eb8292 100644
--- a/src/filters/image.rs
+++ b/src/filters/image.rs
@@ -155,9 +155,4 @@ impl FilterRender for FeImage {
     }
 }
 
-impl FilterEffect for FeImage {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        false
-    }
-}
+impl FilterEffect for FeImage {}
diff --git a/src/filters/lighting.rs b/src/filters/lighting.rs
index db97b2dd..3ce86a4e 100644
--- a/src/filters/lighting.rs
+++ b/src/filters/lighting.rs
@@ -670,12 +670,7 @@ macro_rules! impl_lighting_filter {
             }
         }
 
-        impl FilterEffect for $lighting_type {
-            #[inline]
-            fn is_affected_by_color_interpolation_filters(&self) -> bool {
-                true
-            }
-        }
+        impl FilterEffect for $lighting_type {}
     };
 }
 
diff --git a/src/filters/merge.rs b/src/filters/merge.rs
index 35c598f8..7c56de08 100644
--- a/src/filters/merge.rs
+++ b/src/filters/merge.rs
@@ -131,12 +131,7 @@ impl FilterRender for FeMerge {
     }
 }
 
-impl FilterEffect for FeMerge {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeMerge {}
 
 /// Takes a feMerge and walks its children to produce a list of feMergeNode arguments.
 fn get_parameters(node: &Node) -> Result<Vec<FeMergeNode>, FilterError> {
diff --git a/src/filters/mod.rs b/src/filters/mod.rs
index cdcb89f0..1235129b 100644
--- a/src/filters/mod.rs
+++ b/src/filters/mod.rs
@@ -44,14 +44,7 @@ pub trait FilterRender {
 }
 
 /// A filter primitive interface.
-pub trait FilterEffect: SetAttributes + Draw + FilterRender {
-    /// Returns `true` if this filter primitive is affected by the `color-interpolation-filters`
-    /// property.
-    ///
-    /// Primitives that do color blending (like `feComposite` or `feBlend`) should return `true`
-    /// here, whereas primitives that don't (like `feOffset`) should return `false`.
-    fn is_affected_by_color_interpolation_filters(&self) -> bool;
-}
+pub trait FilterEffect: SetAttributes + Draw + FilterRender {}
 
 // Filter Effects do not need to draw themselves
 impl<T: FilterEffect> Draw for T {}
diff --git a/src/filters/morphology.rs b/src/filters/morphology.rs
index ce135681..65771222 100644
--- a/src/filters/morphology.rs
+++ b/src/filters/morphology.rs
@@ -161,12 +161,7 @@ impl FilterRender for FeMorphology {
     }
 }
 
-impl FilterEffect for FeMorphology {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        false
-    }
-}
+impl FilterEffect for FeMorphology {}
 
 impl Parse for Operator {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {
diff --git a/src/filters/offset.rs b/src/filters/offset.rs
index 3b899d4b..94823106 100644
--- a/src/filters/offset.rs
+++ b/src/filters/offset.rs
@@ -86,9 +86,4 @@ impl FilterRender for FeOffset {
     }
 }
 
-impl FilterEffect for FeOffset {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        false
-    }
-}
+impl FilterEffect for FeOffset {}
diff --git a/src/filters/tile.rs b/src/filters/tile.rs
index 7d086082..df6bde12 100644
--- a/src/filters/tile.rs
+++ b/src/filters/tile.rs
@@ -81,9 +81,4 @@ impl FilterRender for FeTile {
     }
 }
 
-impl FilterEffect for FeTile {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        false
-    }
-}
+impl FilterEffect for FeTile {}
diff --git a/src/filters/turbulence.rs b/src/filters/turbulence.rs
index eac10500..f20fd860 100644
--- a/src/filters/turbulence.rs
+++ b/src/filters/turbulence.rs
@@ -402,12 +402,7 @@ impl FilterRender for FeTurbulence {
     }
 }
 
-impl FilterEffect for FeTurbulence {
-    #[inline]
-    fn is_affected_by_color_interpolation_filters(&self) -> bool {
-        true
-    }
-}
+impl FilterEffect for FeTurbulence {}
 
 impl Parse for StitchTiles {
     fn parse<'i>(parser: &mut Parser<'i, '_>) -> Result<Self, ParseError<'i>> {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]