[gimp/gimp-2-10] Issue 4594: Spotify doesn't open with Gimp open.
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp/gimp-2-10] Issue 4594: Spotify doesn't open with Gimp open.
- Date: Wed, 10 Mar 2021 12:26:29 +0000 (UTC)
commit 9fcc31ea19cf170a591d3cf7307c412077bf9fcf
Author: Jehan <jehan girinstud io>
Date: Wed Mar 10 13:23:27 2021 +0100
Issue 4594: Spotify doesn't open with Gimp open.
GLib has been fixed with commit 00e848fbc.
Add it in our patch list for the Windows installer until we get a
release containing the patch.
(cherry picked from commit 106e13d5db5ceb40a36e22347fb9539ec923eb6d)
...-right-permissions-for-directory-watching.patch | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
---
diff --git a/build/windows/patches/glib-issue-4594-Use-the-right-permissions-for-directory-watching.patch
b/build/windows/patches/glib-issue-4594-Use-the-right-permissions-for-directory-watching.patch
new file mode 100644
index 0000000000..9b2cf34fcc
--- /dev/null
+++ b/build/windows/patches/glib-issue-4594-Use-the-right-permissions-for-directory-watching.patch
@@ -0,0 +1,31 @@
+From 00e848fbc30867f5c24da5845f4f78c92d094edd Mon Sep 17 00:00:00 2001
+From: Luca Bacci <luca bacci982 gmail com>
+Date: Mon, 1 Mar 2021 11:35:58 +0100
+Subject: [PATCH] Use the right permissions for directory watching on Win32
+
+Using FILE_GENERIC_READ | FILE_GENERIC_WRITE access rights for directory monitoring
+might cause problems, as noted in https://gitlab.gnome.org/GNOME/gimp/-/issues/4594.
+
+ReadDirectoryChanges only needs FILE_LIST_DIRECTORY, so use that.
+
+Fixes: https://gitlab.gnome.org/GNOME/gimp/-/issues/4594
+---
+ gio/win32/gwin32fsmonitorutils.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gio/win32/gwin32fsmonitorutils.c b/gio/win32/gwin32fsmonitorutils.c
+index e6b7d1dcd..b47124634 100644
+--- a/gio/win32/gwin32fsmonitorutils.c
++++ b/gio/win32/gwin32fsmonitorutils.c
+@@ -345,7 +345,7 @@ g_win32_fs_monitor_init (GWin32FSMonitorPrivate *monitor,
+ monitor->file_attribs = INVALID_FILE_ATTRIBUTES;
+ monitor->pfni_prev = NULL;
+ monitor->hDirectory = CreateFileW (wdirname_with_long_prefix != NULL ? wdirname_with_long_prefix :
monitor->wfullpath_with_long_prefix,
+- FILE_GENERIC_READ | FILE_GENERIC_WRITE,
++ FILE_LIST_DIRECTORY,
+ FILE_SHARE_DELETE | FILE_SHARE_READ | FILE_SHARE_WRITE,
+ NULL,
+ OPEN_EXISTING,
+--
+2.29.2
+
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]