[gnome-shell] iconGrid: Don't update pages in vfunc_allocate()



commit 0fd394d4ca531c14aa017f43d91a75c1fcfbfc5e
Author: Jonas Dreßler <verdre v0yd nl>
Date:   Tue Feb 23 20:16:00 2021 +0100

    iconGrid: Don't update pages in vfunc_allocate()
    
    vfunc_allocate() is a hot path, and we don't want to do expensive stuff
    there, so avoid updating the pages, which seems unnecessary anyway.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1713>

 js/ui/iconGrid.js | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js
index 30d9cdde31..27ffd733e0 100644
--- a/js/ui/iconGrid.js
+++ b/js/ui/iconGrid.js
@@ -775,8 +775,6 @@ var IconGridLayout = GObject.registerClass({
         if (this._pageWidth === 0 || this._pageHeight === 0)
             throw new Error('IconGridLayout.adaptToSize wasn\'t called before allocation');
 
-        this._updatePages();
-
         const isRtl =
             Clutter.get_default_text_direction() === Clutter.TextDirection.RTL;
         const childSize = this._getChildrenMaxSize();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]