[tracker-miners/wip/carlosg/chain-error-propagation] libtracker-miner: Chain up TrackerBatch errors in TrackerSparqlBuffer




commit e3197bfab4fcc60e12c45fc77fdb81965da884e7
Author: Carlos Garnacho <carlosg gnome org>
Date:   Fri Jun 25 13:03:42 2021 +0200

    libtracker-miner: Chain up TrackerBatch errors in TrackerSparqlBuffer
    
    In case of batch errors, we are returning early here without finishing
    the GTask. The error should be propagated here, so TrackerMinerFiles
    can report errors and follow up.

 src/libtracker-miner/tracker-sparql-buffer.c | 7 -------
 1 file changed, 7 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-sparql-buffer.c b/src/libtracker-miner/tracker-sparql-buffer.c
index 704e61e9e..b7f5d2273 100644
--- a/src/libtracker-miner/tracker-sparql-buffer.c
+++ b/src/libtracker-miner/tracker-sparql-buffer.c
@@ -204,12 +204,6 @@ batch_execute_cb (GObject      *object,
        if (!tracker_batch_execute_finish (TRACKER_BATCH (object),
                                           result,
                                           &error)) {
-               g_critical ("Error executing batch: %s\n", error->message);
-               g_error_free (error);
-               return;
-       }
-
-       if (error) {
                g_task_return_error (update_data->async_task, error);
        } else {
                g_task_return_pointer (update_data->async_task,
@@ -217,7 +211,6 @@ batch_execute_cb (GObject      *object,
                                       (GDestroyNotify) g_ptr_array_unref);
        }
 
-       g_clear_error (&error);
        update_batch_data_free (update_data);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]