[gnome-software/1286-app-pages-no-longer-have-the-app-name-as-the-title] gs-shell: Title of the window not updated with the current page title



commit a33fee71557cc09d52c14d557e4d590b8e840d6f
Author: Milan Crha <mcrha redhat com>
Date:   Tue Jun 22 21:05:02 2021 +0200

    gs-shell: Title of the window not updated with the current page title
    
    The gtk_stack_get_visible_child() returns an old child when being called
    inside stack_notify_visible_child_cb(), thus use the page variable instead,
    which references the page being set as active.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1286

 src/gs-shell.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-shell.c b/src/gs-shell.c
index 07de31596..58319e4e1 100644
--- a/src/gs-shell.c
+++ b/src/gs-shell.c
@@ -530,17 +530,17 @@ stack_notify_visible_child_cb (GObject    *object,
        }
 
        g_clear_object (&shell->main_header_title_binding);
-       shell->main_header_title_binding = g_object_bind_property (gtk_stack_get_visible_child 
(shell->stack_main), "title",
+       shell->main_header_title_binding = g_object_bind_property (page, "title",
                                                                   shell->main_header, "title",
                                                                   G_BINDING_SYNC_CREATE);
 
        g_clear_object (&shell->application_details_header_binding);
-       shell->application_details_header_binding = g_object_bind_property (gtk_stack_get_visible_child 
(shell->stack_sub), "title",
+       shell->application_details_header_binding = g_object_bind_property (page, "title",
                                                                            
shell->application_details_header, "label",
                                                                            G_BINDING_SYNC_CREATE);
 
        g_clear_object (&shell->sub_page_header_title_binding);
-       shell->sub_page_header_title_binding = g_object_bind_property (gtk_stack_get_visible_child 
(shell->stack_sub), "title",
+       shell->sub_page_header_title_binding = g_object_bind_property (page, "title",
                                                                       shell->sub_page_header_title, "label",
                                                                       G_BINDING_SYNC_CREATE);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]