[gimp] libgimp: tooltip added to all widgets in GimpProcedureDialog
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] libgimp: tooltip added to all widgets in GimpProcedureDialog
- Date: Fri, 18 Jun 2021 12:52:25 +0000 (UTC)
commit 38cda060b3696e207239e525f0a3c7c8e243c06b
Author: Mayank Suman <mayanksuman live com>
Date: Thu Jun 17 23:43:08 2021 +0530
libgimp: tooltip added to all widgets in GimpProcedureDialog
Appropriate tooltip is displayed for all widgets in GimpProcedureDialog.
libgimp/gimpproceduredialog.c | 37 ++++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 13 deletions(-)
---
diff --git a/libgimp/gimpproceduredialog.c b/libgimp/gimpproceduredialog.c
index 487b48cf96..d9d27f19d8 100644
--- a/libgimp/gimpproceduredialog.c
+++ b/libgimp/gimpproceduredialog.c
@@ -559,7 +559,6 @@ gimp_procedure_dialog_get_widget (GimpProcedureDialog *dialog,
if (widget_type == G_TYPE_NONE || widget_type == GTK_TYPE_TEXT_VIEW)
{
GtkTextBuffer *buffer;
- const gchar *tooltip;
buffer = gimp_prop_text_buffer_new (G_OBJECT (dialog->priv->config),
property, -1);
@@ -569,10 +568,6 @@ gimp_procedure_dialog_get_widget (GimpProcedureDialog *dialog,
gtk_text_view_set_left_margin (GTK_TEXT_VIEW (widget), 3);
gtk_text_view_set_right_margin (GTK_TEXT_VIEW (widget), 3);
g_object_unref (buffer);
-
- tooltip = g_param_spec_get_blurb (pspec);
- if (tooltip)
- gimp_help_set_help_data (widget, tooltip, NULL);
}
else if (widget_type == GTK_TYPE_ENTRY)
{
@@ -600,12 +595,18 @@ gimp_procedure_dialog_get_widget (GimpProcedureDialog *dialog,
property, G_PARAM_SPEC_TYPE_NAME (pspec));
return NULL;
}
- else if (GIMP_IS_LABELED (widget) || label)
+ else
{
- if (! label)
- label = gimp_labeled_get_label (GIMP_LABELED (widget));
+ const gchar *tooltip = g_param_spec_get_blurb (pspec);
+ if (tooltip)
+ gimp_help_set_help_data (widget, tooltip, NULL);
+ if (GIMP_IS_LABELED (widget) || label)
+ {
+ if (! label)
+ label = gimp_labeled_get_label (GIMP_LABELED (widget));
- gtk_size_group_add_widget (dialog->priv->label_group, label);
+ gtk_size_group_add_widget (dialog->priv->label_group, label);
+ }
}
if ((binding = g_hash_table_lookup (dialog->priv->sensitive_data, property)))
@@ -702,11 +703,15 @@ gimp_procedure_dialog_get_color_widget (GimpProcedureDialog *dialog,
}
else if (GIMP_IS_LABELED (widget))
{
- GtkWidget *label = gimp_labeled_get_label (GIMP_LABELED (widget));
+ GtkWidget *label = gimp_labeled_get_label (GIMP_LABELED (widget));
+ const gchar *tooltip = g_param_spec_get_blurb (pspec);
gtk_size_group_add_widget (dialog->priv->label_group, label);
+ if (tooltip)
+ gimp_help_set_help_data (label, tooltip, NULL);
}
+
gimp_procedure_dialog_check_mnemonic (dialog, widget, property, NULL);
g_hash_table_insert (dialog->priv->widgets, g_strdup (property), widget);
if (g_object_is_floating (widget))
@@ -777,11 +782,17 @@ gimp_procedure_dialog_get_int_combo (GimpProcedureDialog *dialog,
G_STRFUNC, property, G_PARAM_SPEC_TYPE_NAME (pspec));
return NULL;
}
- else if (GIMP_IS_LABELED (widget))
+ else
{
- GtkWidget *label = gimp_labeled_get_label (GIMP_LABELED (widget));
+ const gchar *tooltip = g_param_spec_get_blurb (pspec);
+ if (tooltip)
+ gimp_help_set_help_data (widget, tooltip, NULL);
+ if (GIMP_IS_LABELED (widget))
+ {
+ GtkWidget *label = gimp_labeled_get_label (GIMP_LABELED (widget));
- gtk_size_group_add_widget (dialog->priv->label_group, label);
+ gtk_size_group_add_widget (dialog->priv->label_group, label);
+ }
}
gimp_procedure_dialog_check_mnemonic (dialog, widget, property, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]