[gnome-shell] shellDBus: Properly return from D-Bus methods
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] shellDBus: Properly return from D-Bus methods
- Date: Thu, 17 Jun 2021 21:09:13 +0000 (UTC)
commit 158920924df53198e85d997b33b6e05afb93f2e8
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Jun 17 15:42:14 2021 +0200
shellDBus: Properly return from D-Bus methods
When implementing a D-Bus method synchronously, regular JS methods are
used. That is, whatever the method returns is passed as return value
to the method invocation.
However for asynchronous implementations, we need to explicitly return
a value to the invocation, otherwise the caller will wait until it times
out eventually.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1891>
js/ui/shellDBus.js | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js
index 48e7bb5b89..6574cc5288 100644
--- a/js/ui/shellDBus.js
+++ b/js/ui/shellDBus.js
@@ -217,11 +217,13 @@ var GnomeShell = class {
let sender = invocation.get_sender();
let [dict] = params;
Main.osdMonitorLabeler.show(sender, dict);
+ invocation.return_value(null);
}
HideMonitorLabelsAsync(params, invocation) {
let sender = invocation.get_sender();
Main.osdMonitorLabeler.hide(sender);
+ invocation.return_value(null);
}
_checkOverviewVisibleChanged() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]