[orca] Web: Fix bug causing live region event from children-changed:add to be ignored



commit b379c1a8453832fc871c67703297551dd46fdc55
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Tue Jun 15 16:45:08 2021 +0200

    Web: Fix bug causing live region event from children-changed:add to be ignored
    
    We were mistakenly returning early.

 src/orca/scripts/web/script.py | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index 9dfea04e2..a4ce747ca 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1754,12 +1754,7 @@ class Script(default.Script):
             else:
                 msg = "WEB: Not dumping cache. Focus is %s" % orca_state.locusOfFocus
                 debug.println(debug.LEVEL_INFO, msg, True)
-        else:
-            msg = "WEB: Could not get document for event source"
-            debug.println(debug.LEVEL_INFO, msg, True)
-            return False
-
-        if isLiveRegion:
+        elif isLiveRegion:
             if self.utilities.handleAsLiveRegion(event):
                 msg = "WEB: Event to be handled as live region"
                 debug.println(debug.LEVEL_INFO, msg, True)
@@ -1768,6 +1763,10 @@ class Script(default.Script):
                 msg = "WEB: Ignoring because live region event not to be handled."
                 debug.println(debug.LEVEL_INFO, msg, True)
             return True
+        else:
+            msg = "WEB: Could not get document for event source"
+            debug.println(debug.LEVEL_INFO, msg, True)
+            return False
 
         if self._loadingDocumentContent:
             msg = "WEB: Ignoring because document content is being loaded."


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]