[tracker/wip/carlosg/code-style-checks] bar




commit 567aa6269e1dc7ff1a1e7b1fbc2d5d4e49b1d243
Author: Carlos Garnacho <carlosg gnome org>
Date:   Mon Jun 14 01:21:43 2021 +0200

    bar

 .gitlab-ci.yml | 9 ++++++---
 check-style.py | 5 +++++
 2 files changed, 11 insertions(+), 3 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index e0a63c3ef..005f6efc4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -181,12 +181,15 @@ check-code-style:
     - build-fedora-container@x86_64
   stage: code-review
   script:
-    - export common_parent_sha=$(diff --old-line-format='' --new-line-format='' <(git rev-list 
--first-parent "origin/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_DEFAULT_BRANCH}}") <(git rev-list 
--first-parent HEAD) | head -1) ;
-      ./check-style.py --sha $common_parent_sha ;
+    - git fetch origin master;
+      export common_parent_sha=$(diff --old-line-format='' --new-line-format='' <(git rev-list 
--first-parent "origin/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_DEFAULT_BRANCH}}") <(git rev-list 
--first-parent HEAD) | head -1) ;
+      python3 -u ./check-style.py --sha $common_parent_sha ;
       if [ $? -ne 0 ] ;
       then
         echo -e "Issue the following command in your local tree to apply the suggested changes (needs 
uncrustify installed):\n\n $ git rebase "origin/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_DEFAULT_BRANCH}}" 
--exec \"./check-style.py -r\" \n" ;
-      fi
+      else
+        echo -e "All looks good.\n" ;
+      fi;
   allow_failure: true
 
 .build-template: &build
diff --git a/check-style.py b/check-style.py
index 9ce886117..70fa1ab45 100755
--- a/check-style.py
+++ b/check-style.py
@@ -1,5 +1,6 @@
 #!/bin/env python3
 
+print ("Start")
 import argparse
 import os
 import re
@@ -106,12 +107,16 @@ parser.add_argument('--rewrite', '-r', type=bool,
                     action=argparse.BooleanOptionalAction,
                     help='Whether to amend the result to the last commit (e.g. \'git rebase --exec "%(prog)s 
-r"\')')
 
+print ("Parse args")
 args = parser.parse_args()
 sha = args.sha or 'HEAD^'
 rewrite = args.rewrite
 
+print ("Run diff")
 diff = run_diff(sha)
+print ("Find chunks")
 chunks = find_chunks(diff)
+print ("Reformat chunks")
 changed = reformat_chunks(chunks, rewrite)
 
 if rewrite is True:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]