[libsoup] connection: IO should always be reusable at soup_connection_setup_message_io()

[Carlos Garcia Campos <carlosgc src gnome org>]

commit 2378b2c9961b2e4555033bce00f8b268197a4731
Author: Carlos Garcia Campos <cgarcia igalia com>
Date:   Fri Jun 11 12:24:12 2021 +0200

    connection: IO should always be reusable at soup_connection_setup_message_io()

 libsoup/soup-connection.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/libsoup/soup-connection.c b/libsoup/soup-connection.c
index 4993d976..8fb9b819 100644
--- a/libsoup/soup-connection.c
+++ b/libsoup/soup-connection.c
@@ -1110,10 +1110,8 @@ soup_connection_setup_message_io (SoupConnection *conn,
         if (priv->proxy_uri && soup_message_get_method (msg) == SOUP_METHOD_CONNECT)
                 set_proxy_msg (conn, msg);
 
-        if (!soup_client_message_io_is_reusable (priv->io_data)) {
-                g_clear_pointer (&priv->io_data, soup_client_message_io_destroy);
-                soup_connection_create_io_data (conn);
-        }
+        if (!soup_client_message_io_is_reusable (priv->io_data))
+                g_warn_if_reached ();
 
         return priv->io_data;
 }