[gnome-shell] st/scroll-view: Don't emit superfluous style-changed events on children
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] st/scroll-view: Don't emit superfluous style-changed events on children
- Date: Fri, 30 Jul 2021 14:05:15 +0000 (UTC)
commit 85ffb969246ef37c0c44fc9a01a8ed5832423dd0
Author: Jonas Dreßler <verdre v0yd nl>
Date: Thu Nov 14 08:37:25 2019 +0100
st/scroll-view: Don't emit superfluous style-changed events on children
Since we correctly call the `style_changed` vfunc superclass at the end
of our own function anyway, the style changes will get propagated to the
children of the scrollView inside `st_widget_real_style_changed` anyway.
So remove those unneeded and quite expensive (because they cause the
theme node to be regenerated) calls to `st_widget_style_changed`.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/953>
src/st/st-scroll-view.c | 4 ----
1 file changed, 4 deletions(-)
---
diff --git a/src/st/st-scroll-view.c b/src/st/st-scroll-view.c
index 606701565d..fe7f3313e3 100644
--- a/src/st/st-scroll-view.c
+++ b/src/st/st-scroll-view.c
@@ -752,7 +752,6 @@ static void
st_scroll_view_style_changed (StWidget *widget)
{
StScrollView *self = ST_SCROLL_VIEW (widget);
- StScrollViewPrivate *priv = self->priv;
StThemeNode *theme_node = st_widget_get_theme_node (widget);
gdouble vfade_offset = st_theme_node_get_length (theme_node, "-st-vfade-offset");
@@ -765,9 +764,6 @@ st_scroll_view_style_changed (StWidget *widget)
.right = hfade_offset,
});
- st_widget_style_changed (ST_WIDGET (priv->hscroll));
- st_widget_style_changed (ST_WIDGET (priv->vscroll));
-
ST_WIDGET_CLASS (st_scroll_view_parent_class)->style_changed (widget);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]