[gtk/gtk-4-2: 1/2] gdk/x11: Do not set PPosition hint
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/gtk-4-2: 1/2] gdk/x11: Do not set PPosition hint
- Date: Sat, 24 Jul 2021 23:57:19 +0000 (UTC)
commit da62ff6322a911d18328f6a0572ae48bcea0eea0
Author: Florian Müllner <fmuellner gnome org>
Date: Sat Jul 24 06:32:16 2021 +0200
gdk/x11: Do not set PPosition hint
It is good practice for (floating) window managers to respect explicit
position hints from clients (as long as the window wouldn't end up
off-screen etc.).
Before commit 13d3afa56e9, GTK had a flag for setting the PPosition hint,
but now does so unconditionally. However the real intention is to *not*
request a fixed position, so don't do that.
(cherry picked from commit 4d0c2997cf01f388cdbaf5707d98c08a0e6e165d)
gdk/x11/gdksurface-x11.c | 8 --------
1 file changed, 8 deletions(-)
---
diff --git a/gdk/x11/gdksurface-x11.c b/gdk/x11/gdksurface-x11.c
index 09a3c13b34..865882591f 100644
--- a/gdk/x11/gdksurface-x11.c
+++ b/gdk/x11/gdksurface-x11.c
@@ -2443,14 +2443,6 @@ gdk_x11_surface_set_geometry_hints (GdkSurface *surface,
}
size_hints.flags = 0;
-
- size_hints.flags |= PPosition;
- /* We need to initialize the following obsolete fields because KWM
- * apparently uses these fields if they are non-zero.
- * #@#!#!$!.
- */
- size_hints.x = 0;
- size_hints.y = 0;
if (geom_mask & GDK_HINT_MIN_SIZE)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]