[gnome-shell/wip/lockdown-show-password: 5/5] shellEntry: Don't show "Show Password" menu if entry icon is disabled
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/lockdown-show-password: 5/5] shellEntry: Don't show "Show Password" menu if entry icon is disabled
- Date: Wed, 21 Jul 2021 19:55:42 +0000 (UTC)
commit 740bc4e5e6dd41a1529f187b9101f6b5991db667
Author: Ray Strode <rstrode redhat com>
Date: Wed Jul 21 14:01:48 2021 -0400
shellEntry: Don't show "Show Password" menu if entry icon is disabled
Right now the Show Password menu is shown unconditionally for password
entries, ignoring the org.gnome.desktop.lockdown disable-show-password
key.
StShellEntry now honors that key for its peek icon, and there's little
reason for the peek icon and the menu to ever be out of sync.
This commit forces the menu and the icon to always be in sync, and
so makes the menu lock down work automatically, too.
js/ui/shellEntry.js | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js
index 38f5a836d2..a2010b39e0 100644
--- a/js/ui/shellEntry.js
+++ b/js/ui/shellEntry.js
@@ -39,6 +39,10 @@ var EntryMenu = class extends PopupMenu.PopupMenu {
item.connect('activate', this._onPasswordActivated.bind(this));
this.addMenuItem(item);
this._passwordItem = item;
+
+ this._entry.bind_property('show-peek-icon',
+ this._passwordItem, 'visible',
+ GObject.BindingFlags.SYNC_CREATE);
}
open(animate) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]