[epiphany] resources/gtk: Drop useless viewports in scrolled windows
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] resources/gtk: Drop useless viewports in scrolled windows
- Date: Wed, 14 Jul 2021 19:20:12 +0000 (UTC)
commit 1a4202211185568d0a0e3a4aa92c44bada8d4b68
Author: vanadiae <vanadiae35 gmail com>
Date: Wed Jul 14 18:41:22 2021 +0200
resources/gtk: Drop useless viewports in scrolled windows
A viewport is only needed when the child widget doesn't implement
GtkScrollable. But a viewport is already automatically added in that
case by the GtkScrolledWindow.
So this commit removes the two viewports as they are unnecessary.
Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/987>
src/resources/gtk/bookmark-properties.ui | 21 ++++++++-------------
src/resources/gtk/encoding-dialog.ui | 9 ++-------
2 files changed, 10 insertions(+), 20 deletions(-)
---
diff --git a/src/resources/gtk/bookmark-properties.ui b/src/resources/gtk/bookmark-properties.ui
index 2f2d6b211..c48a908af 100644
--- a/src/resources/gtk/bookmark-properties.ui
+++ b/src/resources/gtk/bookmark-properties.ui
@@ -75,20 +75,15 @@
<property name="propagate_natural_width">True</property>
<property name="propagate_natural_height">True</property>
<child>
- <object class="GtkViewport">
+ <object class="GtkFlowBox" id="tags_box">
<property name="visible">True</property>
- <child>
- <object class="GtkFlowBox" id="tags_box">
- <property name="visible">True</property>
- <property name="homogeneous">True</property>
- <property name="valign">start</property>
- <property name="column_spacing">6</property>
- <property name="row_spacing">6</property>
- <property name="min_children_per_line">2</property>
- <property name="max_children_per_line">3</property>
- <property name="selection_mode">none</property>
- </object>
- </child>
+ <property name="homogeneous">True</property>
+ <property name="valign">start</property>
+ <property name="column_spacing">6</property>
+ <property name="row_spacing">6</property>
+ <property name="min_children_per_line">2</property>
+ <property name="max_children_per_line">3</property>
+ <property name="selection_mode">none</property>
</object>
</child>
</object>
diff --git a/src/resources/gtk/encoding-dialog.ui b/src/resources/gtk/encoding-dialog.ui
index bfc90c761..1e095cbce 100644
--- a/src/resources/gtk/encoding-dialog.ui
+++ b/src/resources/gtk/encoding-dialog.ui
@@ -196,14 +196,9 @@
<property name="hscrollbar_policy">never</property>
<property name="shadow_type">in</property>
<child>
- <object class="GtkViewport">
+ <object class="GtkListBox" id="list_box">
<property name="visible">True</property>
- <child>
- <object class="GtkListBox" id="list_box">
- <property name="visible">True</property>
- <signal name="row-activated" handler="row_activated_cb"/>
- </object>
- </child>
+ <signal name="row-activated" handler="row_activated_cb"/>
</object>
</child>
</object>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]