[gnome-shell/gnome-40] st/scroll-bar: Fix vertical scrollbars in RTL locales



commit cca12d5de965126022e28a2d494354c03c898b18
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Jul 8 23:42:49 2021 +0200

    st/scroll-bar: Fix vertical scrollbars in RTL locales
    
    Commit 0db41a3773e fixed the handling of horizontal scrollbars in
    RTL locales, but accidentally applied the translation to *all*
    scrollbars when handling handle drags and paging. Fix this by
    limiting the mirroring to horizontal bars.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4458
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1910>
    (cherry picked from commit 0e72579364059ba5ee829cdd1d594009f725f991)

 src/st/st-scroll-bar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/st/st-scroll-bar.c b/src/st/st-scroll-bar.c
index 59e9ca8207..01674df65d 100644
--- a/src/st/st-scroll-bar.c
+++ b/src/st/st-scroll-bar.c
@@ -633,7 +633,7 @@ move_slider (StScrollBar *bar,
                             &page_size);
 
   direction = clutter_actor_get_text_direction (CLUTTER_ACTOR (bar));
-  if (direction == CLUTTER_TEXT_DIRECTION_RTL)
+  if (!priv->vertical && direction == CLUTTER_TEXT_DIRECTION_RTL)
     pos = size - pos;
 
   position = ((pos / size)
@@ -778,7 +778,7 @@ trough_paging_cb (StScrollBar *self)
                                        &tx, &ty);
 
   direction = clutter_actor_get_text_direction (CLUTTER_ACTOR (self));
-  if (direction == CLUTTER_TEXT_DIRECTION_RTL)
+  if (!priv->vertical && direction == CLUTTER_TEXT_DIRECTION_RTL)
     page_increment *= -1;
 
   if (priv->vertical)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]