[gnome-shell/gnome-40] shellDBus: Fix FocusApp()
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gnome-40] shellDBus: Fix FocusApp()
- Date: Fri, 9 Jul 2021 22:22:22 +0000 (UTC)
commit b7403058fcee01a7eca05ad47e690aaf56648bed
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Jun 17 22:09:14 2021 +0200
shellDBus: Fix FocusApp()
The appDisplay used to be accessible via the viewSelector, but
that is gone now. Commit c09c070b15 adjusted the code, but the
replacement uses a Main.overview.appDisplay accessor that never
existed, whoops.
Fix this by exposing a new selectApp() method directly on the
overview, so we don't have to shuffle the appDisplay through
controls → overviewActor → overview.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1891>
(cherry picked from commit c90fb27a2f3d3047e185190089cef648bce6b58a)
js/ui/overview.js | 5 +++++
js/ui/shellDBus.js | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/overview.js b/js/ui/overview.js
index e6b3b26156..529779ea8b 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -642,6 +642,11 @@ var Overview = class {
this.show(OverviewControls.ControlsState.APP_GRID);
}
+ selectApp(id) {
+ this.showApps();
+ this._overview.controls.appDisplay.selectApp(id);
+ }
+
runStartupAnimation(callback) {
Main.panel.style = 'transition-duration: 0ms;';
diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js
index 3028dfb68f..39f142af95 100644
--- a/js/ui/shellDBus.js
+++ b/js/ui/shellDBus.js
@@ -100,8 +100,7 @@ var GnomeShell = class {
}
FocusApp(id) {
- this.ShowApplications();
- Main.overview.appDisplay.selectApp(id);
+ Main.overview.selectApp(id);
}
ShowApplications() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]