[gimp] libgimpwidgets: use g_printerr() instead of g_warning() for app icons.



commit 4a00a993f23c229b0d31ac170b4fb69d3e7763d6
Author: Jehan <jehan girinstud io>
Date:   Tue Jul 6 18:49:04 2021 +0200

    libgimpwidgets: use g_printerr() instead of g_warning() for app icons.
    
    Unit testing consider warnings as criticals and doesn't like when it
    cannot find the installed application icons. To fix the `make check`,
    just print the missing icon information to stderr, but don't make it a
    GLib warning.

 libgimpwidgets/gimpwidgets-private.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/libgimpwidgets/gimpwidgets-private.c b/libgimpwidgets/gimpwidgets-private.c
index f435c35b34..1ce357c971 100644
--- a/libgimpwidgets/gimpwidgets-private.c
+++ b/libgimpwidgets/gimpwidgets-private.c
@@ -102,7 +102,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
   if (pixbuf)
     icons = g_list_prepend (icons, pixbuf);
   else
-    g_warning ("Application icon missing: %s", path);
+    g_printerr ("Application icon missing: %s", path);
   g_free (path);
 
   path   = g_build_filename (base_dir, "32x32/apps/gimp.png", NULL);
@@ -110,7 +110,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
   if (pixbuf)
     icons = g_list_prepend (icons, pixbuf);
   else
-    g_warning ("Application icon missing: %s", path);
+    g_printerr ("Application icon missing: %s", path);
   g_free (path);
 
   path   = g_build_filename (base_dir, "48x48/apps/gimp.png", NULL);
@@ -118,7 +118,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
   if (pixbuf)
     icons = g_list_prepend (icons, pixbuf);
   else
-    g_warning ("Application icon missing: %s", path);
+    g_printerr ("Application icon missing: %s", path);
   g_free (path);
 
   path   = g_build_filename (base_dir, "64x64/apps/gimp.png", NULL);
@@ -126,7 +126,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
   if (pixbuf)
     icons = g_list_prepend (icons, pixbuf);
   else
-    g_warning ("Application icon missing: %s", path);
+    g_printerr ("Application icon missing: %s", path);
   g_free (path);
 
   path   = g_build_filename (base_dir, "scalable/apps/gimp.svg", NULL);
@@ -157,7 +157,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
     }
   else
     {
-      g_warning ("Application icon missing: %s", path);
+      g_printerr ("Application icon missing: %s", path);
     }
   g_free (path);
 
@@ -166,7 +166,7 @@ gimp_widgets_init (GimpHelpFunc          standard_help_func,
   if (pixbuf)
     icons = g_list_prepend (icons, pixbuf);
   else
-    g_warning ("Application icon missing: %s", path);
+    g_printerr ("Application icon missing: %s", path);
   g_free (path);
 
   gtk_window_set_default_icon_list (icons);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]