[libgda] Test: Removes unused variable
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda] Test: Removes unused variable
- Date: Sat, 30 Jan 2021 22:18:51 +0000 (UTC)
commit 821ebf4fcf66d3c631c64cb0bbddf1b1594694c8
Author: Pavlo Solntsev <p sun fun gmail com>
Date: Wed Jun 17 13:19:55 2020 -0500
Test: Removes unused variable
This is bug. Since params_provided is initialized
to 0 and never changes.
See for details: https://gitlab.gnome.org/GNOME/libgda/-/issues/217
tests/providers/check_mysql.c | 9 ++-------
tests/providers/check_postgres.c | 1 -
tests/providers/check_sqlcipher.c | 9 ++-------
tests/providers/check_sqlite.c | 9 ++-------
tests/providers/prov-test-common.c | 1 -
5 files changed, 6 insertions(+), 23 deletions(-)
---
diff --git a/tests/providers/check_mysql.c b/tests/providers/check_mysql.c
index a8462830e..53e46a243 100644
--- a/tests/providers/check_mysql.c
+++ b/tests/providers/check_mysql.c
@@ -23,7 +23,6 @@
extern GdaProviderInfo *pinfo;
extern GdaConnection *cnc;
-extern gboolean params_provided;
int
main (G_GNUC_UNUSED int argc, G_GNUC_UNUSED char **argv)
@@ -66,11 +65,7 @@ main (G_GNUC_UNUSED int argc, G_GNUC_UNUSED char **argv)
number_failed += prov_test_common_clean ();
}
- if (! params_provided)
- return EXIT_SUCCESS;
- else {
- g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
- return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
- }
+ g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
+ return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
}
diff --git a/tests/providers/check_postgres.c b/tests/providers/check_postgres.c
index fef2e32bb..81a2c4713 100644
--- a/tests/providers/check_postgres.c
+++ b/tests/providers/check_postgres.c
@@ -28,7 +28,6 @@
extern GdaProviderInfo *pinfo;
extern GdaConnection *cnc;
-extern gboolean params_provided;
extern gboolean fork_tests;
//static int test_timestamp_change_format (void);
diff --git a/tests/providers/check_sqlcipher.c b/tests/providers/check_sqlcipher.c
index 5b9c8d354..971a7b661 100644
--- a/tests/providers/check_sqlcipher.c
+++ b/tests/providers/check_sqlcipher.c
@@ -24,7 +24,6 @@
extern GdaProviderInfo *pinfo;
extern GdaConnection *cnc;
-extern gboolean params_provided;
extern gboolean fork_tests;
int
@@ -60,11 +59,7 @@ main (G_GNUC_UNUSED int argc, G_GNUC_UNUSED char **argv)
number_failed += prov_test_common_clean ();
}
- if (! params_provided)
- return EXIT_SUCCESS;
- else {
- g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
- return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
- }
+ g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
+ return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
}
diff --git a/tests/providers/check_sqlite.c b/tests/providers/check_sqlite.c
index 7f1ba6906..44e071529 100644
--- a/tests/providers/check_sqlite.c
+++ b/tests/providers/check_sqlite.c
@@ -23,7 +23,6 @@
extern GdaProviderInfo *pinfo;
extern GdaConnection *cnc;
-extern gboolean params_provided;
extern gboolean fork_tests;
int
@@ -59,11 +58,7 @@ main (G_GNUC_UNUSED int argc, G_GNUC_UNUSED char **argv)
number_failed += prov_test_common_clean ();
}
- if (! params_provided)
- return EXIT_SUCCESS;
- else {
- g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
- return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
- }
+ g_print ("Test %s\n", (number_failed == 0) ? "Ok" : "failed");
+ return (number_failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
}
diff --git a/tests/providers/prov-test-common.c b/tests/providers/prov-test-common.c
index cc47e4345..d84c9682a 100644
--- a/tests/providers/prov-test-common.c
+++ b/tests/providers/prov-test-common.c
@@ -32,7 +32,6 @@
GdaProviderInfo *pinfo;
GdaConnection *cnc;
-gboolean params_provided;
gboolean fork_tests = TRUE;
/*
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]