[gnome-software/1111-app-details-addons: 2/3] details: Show addon row after signal connection




commit 9d328097f8eab08f838b99f3f77a42c2ab8de2ab
Author: Phaedrus Leeds <mwleeds endlessos org>
Date:   Thu Jan 28 16:01:31 2021 -0800

    details: Show addon row after signal connection
    
    It's unlikely to make a difference, but connecting to signals before
    showing a widget seems like a good practice, so the widget isn't shown
    in an unusable state, even briefly.

 src/gs-details-page.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index f363d011..1b550382 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1489,15 +1489,16 @@ gs_details_page_refresh_addons (GsDetailsPage *self)
 
                row = gs_app_addon_row_new (addon);
 
-               gtk_container_add (GTK_CONTAINER (self->list_box_addons), row);
-               gtk_widget_show (row);
-
                g_signal_connect (row, "notify::selected",
                                  G_CALLBACK (gs_details_page_addon_selected_cb),
                                  self);
                g_signal_connect (row, "remove-button-clicked",
                                  G_CALLBACK (gs_details_page_addon_remove_cb),
                                  self);
+
+               gtk_container_add (GTK_CONTAINER (self->list_box_addons), row);
+               gtk_widget_show (row);
+
        }
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]