[gnome-settings-daemon] media-keys: Don't plonk on screenshot errors

[Carlos Garnacho <carlosg src gnome org>]

commit d81127812bdeebc6c0f4c406640123a34c4ddda2
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Jan 27 12:11:03 2021 +0100

    media-keys: Don't plonk on screenshot errors
    
    From a user's point of view, it doesn't matter whether gnome-shell's
    screenshot API returned `false` or a D-Bus error: Both mean that
    a screenshot was not taken.
    
    Treating them differently is therefore slightly confusing, so stop
    doing that: Rely on the lack of flash effect and shutter sound as
    feedback and remove the "plonk" sound played after errors.

 plugins/media-keys/gsd-screenshot-utils.c | 8 --------
 1 file changed, 8 deletions(-)
---
diff --git a/plugins/media-keys/gsd-screenshot-utils.c b/plugins/media-keys/gsd-screenshot-utils.c
index 17ea32d9..b3eb6593 100644
--- a/plugins/media-keys/gsd-screenshot-utils.c
+++ b/plugins/media-keys/gsd-screenshot-utils.c
@@ -76,12 +76,6 @@ screenshot_context_free (ScreenshotContext *ctx)
   g_slice_free (ScreenshotContext, ctx);
 }
 
-static void
-screenshot_play_error_sound_effect (void)
-{
-  screenshot_play_sound_effect ("dialog-error", _("Unable to capture a screenshot"));
-}
-
 static void
 screenshot_save_to_recent (ScreenshotContext *ctx)
 {
@@ -108,7 +102,6 @@ bus_call_ready_cb (GObject *source,
 
   if (error != NULL)
     {
-      screenshot_play_error_sound_effect ();
       g_warning ("Failed to save a screenshot: %s\n", error->message);
       g_error_free (error);
       screenshot_context_free (ctx);
@@ -218,7 +211,6 @@ bus_connection_ready_cb (GObject *source,
 
   if (error != NULL)
     {
-      screenshot_play_error_sound_effect ();
       g_warning ("Failed to save a screenshot: %s\n", error->message);
       g_error_free (error);
       screenshot_context_free (ctx);