[geary/mjog/fix-missing-widget-destroy-chainups] client: Ensure Gtk.Widget::destroy overrides are correct




commit 1732166da32fb9ef597fe5a27e1eafbe6c98c40c
Author: Michael Gratton <mike vee net>
Date:   Wed Jan 20 22:27:05 2021 +1100

    client: Ensure Gtk.Widget::destroy overrides are correct
    
    Remove unneeded override in `Composer.Box`, add missing chain up in
    `Components.InfoBar`. The former may fix an occasional warning with
    composers on the command stack, the latter does fix a crash when
    MainWindow is destroyed.

 src/client/components/components-info-bar.vala | 1 +
 src/client/composer/composer-box.vala          | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/client/components/components-info-bar.vala b/src/client/components/components-info-bar.vala
index aa8b3cecd..93a1c7173 100644
--- a/src/client/components/components-info-bar.vala
+++ b/src/client/components/components-info-bar.vala
@@ -168,6 +168,7 @@ public class Components.InfoBar : Gtk.Box {
     /* {@inheritDoc} */
     public override void destroy() {
         this.plugin = null;
+        base.destroy();
     }
 
     public Gtk.Box get_action_area() {
diff --git a/src/client/composer/composer-box.vala b/src/client/composer/composer-box.vala
index 1ea515ced..851fc1ad4 100644
--- a/src/client/composer/composer-box.vala
+++ b/src/client/composer/composer-box.vala
@@ -54,8 +54,4 @@ public class Composer.Box : Gtk.Frame, Container {
         destroy();
     }
 
-    public override void destroy() {
-        debug("Composer.Box::destroy");
-    }
-
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]