[epiphany] Remove smooth scrolling option



commit 7ddaa377a4154c44e6ffb5c8375a74103a738e48
Author: Jan-Michael Brummer <jan brummer tabos org>
Date:   Sun Jan 10 17:28:53 2021 +0100

    Remove smooth scrolling option
    
    Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/802

 data/org.gnome.epiphany.gschema.xml     |  5 -----
 embed/ephy-embed-prefs.c                |  4 ----
 lib/ephy-prefs.h                        |  2 --
 src/preferences/prefs-general-page.c    |  8 --------
 src/resources/gtk/prefs-general-page.ui | 14 --------------
 5 files changed, 33 deletions(-)
---
diff --git a/data/org.gnome.epiphany.gschema.xml b/data/org.gnome.epiphany.gschema.xml
index 35ed1993c..1ef7cbfb3 100644
--- a/data/org.gnome.epiphany.gschema.xml
+++ b/data/org.gnome.epiphany.gschema.xml
@@ -166,11 +166,6 @@
                        <summary>Allow popups</summary>
                        <description>Allow sites to open new windows using JavaScript (if JavaScript is 
enabled).</description>
                </key>
-               <key type="b" name="enable-smooth-scrolling">
-                       <default>true</default>
-                       <summary>Enable smooth scrolling</summary>
-                        <description>Whether to enable smooth scrolling.</description>
-               </key>
                <key type="s" name="user-agent">
                        <default>''</default>
                        <summary>User agent</summary>
diff --git a/embed/ephy-embed-prefs.c b/embed/ephy-embed-prefs.c
index 705dfced2..0ad1fb2e8 100644
--- a/embed/ephy-embed-prefs.c
+++ b/embed/ephy-embed-prefs.c
@@ -599,10 +599,6 @@ ephy_embed_prefs_init (gpointer user_data)
                    EPHY_PREFS_WEB_DEFAULT_ENCODING,
                    webkit_settings, DEFAULT_ENCODING_SETTING,
                    G_SETTINGS_BIND_GET);
-  g_settings_bind (EPHY_SETTINGS_WEB,
-                   EPHY_PREFS_WEB_ENABLE_SMOOTH_SCROLLING,
-                   webkit_settings, "enable-smooth-scrolling",
-                   G_SETTINGS_BIND_GET);
   g_settings_bind (EPHY_SETTINGS_WEB,
                    EPHY_PREFS_WEB_ENABLE_SITE_SPECIFIC_QUIRKS,
                    webkit_settings, "enable-site-specific-quirks",
diff --git a/lib/ephy-prefs.h b/lib/ephy-prefs.h
index 89d567e6c..b6d219136 100644
--- a/lib/ephy-prefs.h
+++ b/lib/ephy-prefs.h
@@ -100,7 +100,6 @@ static const char * const ephy_prefs_state_schema[] = {
 #define EPHY_PREFS_WEB_ENABLE_USER_JS               "enable-user-js"
 #define EPHY_PREFS_WEB_ENABLE_POPUPS                "enable-popups"
 #define EPHY_PREFS_WEB_ENABLE_SPELL_CHECKING        "enable-spell-checking"
-#define EPHY_PREFS_WEB_ENABLE_SMOOTH_SCROLLING      "enable-smooth-scrolling"
 #define EPHY_PREFS_WEB_USER_AGENT                   "user-agent"
 #define EPHY_PREFS_WEB_DEFAULT_ENCODING             "default-encoding"
 #define EPHY_PREFS_WEB_ENABLE_ADBLOCK               "enable-adblock"
@@ -131,7 +130,6 @@ static const char * const ephy_prefs_web_schema[] = {
   EPHY_PREFS_WEB_ENABLE_USER_JS,
   EPHY_PREFS_WEB_ENABLE_POPUPS,
   EPHY_PREFS_WEB_ENABLE_SPELL_CHECKING,
-  EPHY_PREFS_WEB_ENABLE_SMOOTH_SCROLLING,
   EPHY_PREFS_WEB_USER_AGENT,
   EPHY_PREFS_WEB_DEFAULT_ENCODING,
   EPHY_PREFS_WEB_ENABLE_ADBLOCK,
diff --git a/src/preferences/prefs-general-page.c b/src/preferences/prefs-general-page.c
index 1ea40e4d0..4d8af93dd 100644
--- a/src/preferences/prefs-general-page.c
+++ b/src/preferences/prefs-general-page.c
@@ -81,7 +81,6 @@ struct _PrefsGeneralPage {
 
   /* Browsing */
   GtkWidget *browsing_box;
-  GtkWidget *enable_smooth_scrolling_switch;
   GtkWidget *enable_mouse_gesture_switch;
   GtkWidget *enable_switch_to_new_tab;
 
@@ -1078,7 +1077,6 @@ prefs_general_page_class_init (PrefsGeneralPageClass *klass)
 
   /* Browsing */
   gtk_widget_class_bind_template_child (widget_class, PrefsGeneralPage, browsing_box);
-  gtk_widget_class_bind_template_child (widget_class, PrefsGeneralPage, enable_smooth_scrolling_switch);
   gtk_widget_class_bind_template_child (widget_class, PrefsGeneralPage, enable_mouse_gesture_switch);
   gtk_widget_class_bind_template_child (widget_class, PrefsGeneralPage, enable_switch_to_new_tab);
 
@@ -1250,12 +1248,6 @@ setup_general_page (PrefsGeneralPage *general_page)
   /* ======================================================================== */
   /* ========================== Browsing ==================================== */
   /* ======================================================================== */
-  g_settings_bind (web_settings,
-                   EPHY_PREFS_WEB_ENABLE_SMOOTH_SCROLLING,
-                   general_page->enable_smooth_scrolling_switch,
-                   "active",
-                   G_SETTINGS_BIND_DEFAULT);
-
   g_settings_bind (web_settings,
                    EPHY_PREFS_WEB_ENABLE_MOUSE_GESTURES,
                    general_page->enable_mouse_gesture_switch,
diff --git a/src/resources/gtk/prefs-general-page.ui b/src/resources/gtk/prefs-general-page.ui
index c8b443f2d..83123bb04 100644
--- a/src/resources/gtk/prefs-general-page.ui
+++ b/src/resources/gtk/prefs-general-page.ui
@@ -258,20 +258,6 @@
       <object class="HdyPreferencesGroup" id="browsing_box">
         <property name="title" translatable="yes">Browsing</property>
         <property name="visible">True</property>
-        <child>
-          <object class="HdyActionRow">
-            <property name="activatable_widget">enable_smooth_scrolling_switch</property>
-            <property name="title" translatable="yes">Sm_ooth Scrolling</property>
-            <property name="use_underline">True</property>
-            <property name="visible">True</property>
-            <child>
-              <object class="GtkSwitch" id="enable_smooth_scrolling_switch">
-                <property name="valign">center</property>
-                <property name="visible">True</property>
-              </object>
-            </child>
-          </object>
-        </child>
         <child>
           <object class="HdyActionRow">
             <property name="activatable_widget">enable_mouse_gesture_switch</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]