[gtk/wip/carlosg/mark-valid-portal-settings] gdk/wayland: Mark matched settings from the portal as valid




commit 97b5fad13159d19ccc2c3b9d222f99f100cc0043
Author: Carlos Garnacho <carlosg gnome org>
Date:   Thu Jan 14 15:47:36 2021 +0100

    gdk/wayland: Mark matched settings from the portal as valid
    
    Commit e6209de9625 added some checks on TranslationEntry.valid in
    order to figure out whether using the new font settings or the
    old g-s-d ones. However that's only set in the non-sandboxed case.
    
    This makes sandboxed applications fallback to the old (and also
    non-existing with modern g-s-d) settings, possibly resulting in
    ugly defaults being picked.
    
    Fix this by also marking TranslationEntry elements as valid when
    using the settings portal, precisely those entries that we are able
    to read and match with our own table.

 gdk/wayland/gdkdisplay-wayland.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/gdk/wayland/gdkdisplay-wayland.c b/gdk/wayland/gdkdisplay-wayland.c
index 39799e2762..f5ea972fa2 100644
--- a/gdk/wayland/gdkdisplay-wayland.c
+++ b/gdk/wayland/gdkdisplay-wayland.c
@@ -1836,6 +1836,7 @@ settings_portal_changed (GDBusProxy *proxy,
           char *a = g_variant_print (value, FALSE);
           g_debug ("Using changed portal setting %s %s: %s", namespace, name, a);
           g_free (a);
+          entry->valid = TRUE;
           apply_portal_setting (entry, value, display);
           gdk_display_setting_changed (display, entry->setting);
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]