[gnome-shell/wip/fmuellner/gtk4: 27/39] extensions-app: Use consistent style for property names




commit 8eb1792d390ccea62f9ab56c44fd653b1113ca79
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Apr 15 20:27:15 2020 +0200

    extensions-app: Use consistent style for property names
    
    GtkBuilder understands both dashes and underscores in property names,
    and we currently use a mix of both. The actual properties use dashes,
    so settle on that.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1495>

 .../extensions-app/data/ui/extension-row.ui        | 90 +++++++++++-----------
 .../extensions-app/data/ui/extensions-window.ui    | 64 +++++++--------
 2 files changed, 77 insertions(+), 77 deletions(-)
---
diff --git a/subprojects/extensions-app/data/ui/extension-row.ui 
b/subprojects/extensions-app/data/ui/extension-row.ui
index e0ade920ba..5aa18c4bbd 100644
--- a/subprojects/extensions-app/data/ui/extension-row.ui
+++ b/subprojects/extensions-app/data/ui/extension-row.ui
@@ -9,7 +9,7 @@
       <object class="GtkGrid">
         <property name="visible">True</property>
         <property name="margin">12</property>
-        <property name="column_spacing">12</property>
+        <property name="column-spacing">12</property>
         <child>
           <object class="GtkLabel" id="nameLabel">
             <property name="visible">True</property>
@@ -17,8 +17,8 @@
         </child>
         <child>
           <object class="GtkImage" id="errorIcon">
-            <property name="no_show_all">True</property>
-            <property name="icon_name">dialog-error-symbolic</property>
+            <property name="no-show-all">True</property>
+            <property name="icon-name">dialog-error-symbolic</property>
             <style>
               <class name="error"/>
             </style>
@@ -26,8 +26,8 @@
         </child>
         <child>
           <object class="GtkImage" id="updatesIcon">
-            <property name="no_show_all">True</property>
-            <property name="icon_name">software-update-available-symbolic</property>
+            <property name="no-show-all">True</property>
+            <property name="icon-name">software-update-available-symbolic</property>
             <style>
               <class name="warning"/>
             </style>
@@ -41,13 +41,13 @@
         </child>
         <child>
           <object class="GtkButton" id="prefsButton">
-            <property name="no_show_all">True</property>
+            <property name="no-show-all">True</property>
             <property name="visible"
                       bind-source="prefsButton"
                       bind-property="sensitive"
                       bind-flags="sync-create"/>
-            <property name="can_focus">True</property>
-            <property name="receives_default">True</property>
+            <property name="can-focus">True</property>
+            <property name="receives-default">True</property>
             <property name="valign">center</property>
             <property name="action-name">row.show-prefs</property>
             <style>
@@ -57,7 +57,7 @@
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
-                <property name="icon_name">emblem-system-symbolic</property>
+                <property name="icon-name">emblem-system-symbolic</property>
               </object>
             </child>
           </object>
@@ -65,7 +65,7 @@
         <child>
           <object class="GtkSwitch" id="switch">
             <property name="visible">True</property>
-            <property name="can_focus">True</property>
+            <property name="can-focus">True</property>
             <property name="valign">center</property>
             <property name="action-name">row.enabled</property>
           </object>
@@ -78,8 +78,8 @@
          <child>
           <object class="GtkButton" id="revealButton">
             <property name="visible">True</property>
-            <property name="can_focus">True</property>
-            <property name="receives_default">True</property>
+            <property name="can-focus">True</property>
+            <property name="receives-default">True</property>
             <property name="valign">center</property>
             <style>
               <class name="details-button"/>
@@ -89,7 +89,7 @@
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
-                <property name="icon_name">pan-end-symbolic</property>
+                <property name="icon-name">pan-end-symbolic</property>
               </object>
             </child>
           </object>
@@ -100,9 +100,9 @@
             <child>
               <object class="GtkGrid">
                 <property name="visible">True</property>
-                <property name="margin_top">12</property>
-                <property name="row_spacing">6</property>
-                <property name="column_spacing">12</property>
+                <property name="margin-top">12</property>
+                <property name="row-spacing">6</property>
+                <property name="column-spacing">12</property>
                 <child>
                   <object class="GtkLabel">
                     <property name="visible">True</property>
@@ -117,7 +117,7 @@
                   <object class="GtkLabel" id="descriptionLabel">
                     <property name="visible">True</property>
                     <property name="ellipsize">end</property>
-                    <property name="max_width_chars">60</property>
+                    <property name="max-width-chars">60</property>
                     <property name="xalign">0</property>
                     <property name="yalign">0</property>
                   </object>
@@ -128,7 +128,7 @@
                               bind-source="versionLabel"
                               bind-property="visible"
                               bind-flags="sync-create"/>
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="label" translatable="yes">Version</property>
                     <property name="xalign">0</property>
                     <style>
@@ -136,18 +136,18 @@
                     </style>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">1</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">1</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkLabel" id="versionLabel">
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="xalign">0</property>
                   </object>
                   <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">1</property>
+                    <property name="left-attach">1</property>
+                    <property name="top-attach">1</property>
                   </packing>
                 </child>
                 <child>
@@ -156,7 +156,7 @@
                               bind-source="authorLabel"
                               bind-property="visible"
                               bind-flags="sync-create"/>
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="label" translatable="yes">Author</property>
                     <property name="xalign">0</property>
                     <style>
@@ -164,18 +164,18 @@
                     </style>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">2</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">2</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkLabel" id="authorLabel">
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="xalign">0</property>
                   </object>
                   <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">2</property>
+                    <property name="left-attach">1</property>
+                    <property name="top-attach">2</property>
                   </packing>
                 </child>
                 <child>
@@ -184,7 +184,7 @@
                               bind-source="errorLabel"
                               bind-property="visible"
                               bind-flags="sync-create"/>
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="label" translatable="yes">Error</property>
                     <property name="xalign">0</property>
                     <property name="yalign">0</property>
@@ -193,34 +193,34 @@
                     </style>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">3</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">3</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkLabel" id="errorLabel">
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="selectable">True</property>
                     <property name="wrap">True</property>
-                    <property name="max_width_chars">60</property>
+                    <property name="max-width-chars">60</property>
                     <property name="xalign">0</property>
                   </object>
                   <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">3</property>
+                    <property name="left-attach">1</property>
+                    <property name="top-attach">3</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkButton">
                     <property name="visible">True</property>
                     <property name="label" translatable="yes">Website</property>
-                    <property name="action_name">row.show-url</property>
+                    <property name="action-name">row.show-url</property>
                     <property name="valign">end</property>
                     <property name="margin-top">12</property>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">4</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">4</property>
                   </packing>
                 </child>
                 <child>
@@ -229,9 +229,9 @@
                               bind-source="removeButton"
                               bind-property="sensitive"
                               bind-flags="sync-create"/>
-                    <property name="no_show_all">True</property>
+                    <property name="no-show-all">True</property>
                     <property name="label" translatable="yes">Remove…</property>
-                    <property name="action_name">row.uninstall</property>
+                    <property name="action-name">row.uninstall</property>
                     <property name="hexpand">True</property>
                     <property name="halign">end</property>
                     <property name="valign">end</property>
@@ -240,16 +240,16 @@
                     </style>
                   </object>
                   <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">4</property>
+                    <property name="left-attach">1</property>
+                    <property name="top-attach">4</property>
                   </packing>
                 </child>
               </object>
             </child>
           </object>
           <packing>
-            <property name="left_attach">0</property>
-            <property name="top_attach">1</property>
+            <property name="left-attach">0</property>
+            <property name="top-attach">1</property>
             <property name="width">8</property>
           </packing>
         </child>
diff --git a/subprojects/extensions-app/data/ui/extensions-window.ui 
b/subprojects/extensions-app/data/ui/extensions-window.ui
index fa710d01e4..4bc4156c5c 100644
--- a/subprojects/extensions-app/data/ui/extensions-window.ui
+++ b/subprojects/extensions-app/data/ui/extensions-window.ui
@@ -25,7 +25,7 @@
           <object class="GtkLabel">
             <property name="visible">True</property>
             <property name="label" translatable="yes">To find and add extensions, visit &lt;a 
href="https://extensions.gnome.org"&gt;extensions.gnome.org&lt;/a&gt;.</property>
-            <property name="use_markup">True</property>
+            <property name="use-markup">True</property>
             <property name="xalign">0</property>
           </object>
         </child>
@@ -34,7 +34,7 @@
             <property name="visible">True</property>
             <property name="label" translatable="yes">Warning</property>
             <property name="xalign">0</property>
-            <property name="margin_top">6</property>
+            <property name="margin-top">6</property>
             <attributes>
               <attribute name="weight" value="bold"/>
             </attributes>
@@ -45,7 +45,7 @@
             <property name="visible">True</property>
             <property name="label" translatable="yes">Extensions can cause system issues, including 
performance problems. If you encounter problems with your system, it is recommended to disable all 
extensions.</property>
             <property name="wrap">True</property>
-            <property name="max_width_chars">40</property>
+            <property name="max-width-chars">40</property>
             <property name="xalign">0</property>
           </object>
         </child>
@@ -53,13 +53,13 @@
     </child>
   </object>
   <template class="ExtensionsWindow" parent="GtkApplicationWindow">
-    <property name="default_width">800</property>
-    <property name="default_height">500</property>
+    <property name="default-width">800</property>
+    <property name="default-height">500</property>
     <property name="title" translatable="yes">Extensions</property>
     <child type="titlebar">
       <object class="GtkHeaderBar">
         <property name="visible">True</property>
-        <property name="show_close_button">True</property>
+        <property name="show-close-button">True</property>
         <child>
           <object class="GtkMenuButton">
             <property name="visible">True</property>
@@ -67,7 +67,7 @@
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
-                <property name="icon_name">dialog-information-symbolic</property>
+                <property name="icon-name">dialog-information-symbolic</property>
               </object>
             </child>
           </object>
@@ -75,34 +75,34 @@
         <child>
           <object class="GtkMenuButton" id="menuButton">
             <property name="visible">True</property>
-            <property name="can_focus">True</property>
-            <property name="receives_default">True</property>
-            <property name="menu_model">primary-menu</property>
+            <property name="can-focus">True</property>
+            <property name="receives-default">True</property>
+            <property name="menu-model">primary-menu</property>
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
-                <property name="icon_name">open-menu-symbolic</property>
+                <property name="icon-name">open-menu-symbolic</property>
               </object>
             </child>
           </object>
           <packing>
-            <property name="pack_type">end</property>
+            <property name="pack-type">end</property>
           </packing>
         </child>
         <child>
           <object class="GtkToggleButton" id="searchButton">
             <property name="visible">True</property>
-            <property name="can_focus">True</property>
-            <property name="receives_default">True</property>
+            <property name="can-focus">True</property>
+            <property name="receives-default">True</property>
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
-                <property name="icon_name">edit-find-symbolic</property>
+                <property name="icon-name">edit-find-symbolic</property>
               </object>
             </child>
           </object>
           <packing>
-            <property name="pack_type">end</property>
+            <property name="pack-type">end</property>
           </packing>
         </child>
         <child>
@@ -112,7 +112,7 @@
             <property name="valign">center</property>
           </object>
           <packing>
-            <property name="pack_type">end</property>
+            <property name="pack-type">end</property>
           </packing>
         </child>
       </object>
@@ -139,12 +139,12 @@
         <child>
           <object class="GtkStack" id="mainStack">
             <property name="visible">True</property>
-            <property name="transition_type">crossfade</property>
+            <property name="transition-type">crossfade</property>
             <property name="vexpand">True</property>
             <child>
               <object class="GtkScrolledWindow" id="scrolledWindow">
                 <property name="visible">True</property>
-                <property name="hscrollbar_policy">never</property>
+                <property name="hscrollbar-policy">never</property>
                 <child>
                   <object class="GtkViewport">
                     <property name="visible">True</property>
@@ -172,8 +172,8 @@
                         <child>
                           <object class="GtkListBox" id="userList">
                             <property name="visible">True</property>
-                            <property name="selection_mode">none</property>
-                            <property name="margin_bottom">24</property>
+                            <property name="selection-mode">none</property>
+                            <property name="margin-bottom">24</property>
                             <style>
                               <class name="frame"/>
                             </style>
@@ -196,7 +196,7 @@
                         <child>
                           <object class="GtkListBox" id="systemList">
                             <property name="visible">True</property>
-                            <property name="selection_mode">none</property>
+                            <property name="selection-mode">none</property>
                             <style>
                               <class name="frame"/>
                             </style>
@@ -221,8 +221,8 @@
                 <child>
                   <object class="GtkImage">
                     <property name="visible">True</property>
-                    <property name="pixel_size">96</property>
-                    <property name="icon_name">org.gnome.Extensions-symbolic</property>
+                    <property name="pixel-size">96</property>
+                    <property name="icon-name">org.gnome.Extensions-symbolic</property>
                   </object>
                 </child>
                 <child>
@@ -243,10 +243,10 @@
             <child>
               <object class="GtkBox">
                 <property name="visible">True</property>
-                <property name="margin_left">100</property>
-                <property name="margin_right">100</property>
-                <property name="margin_top">100</property>
-                <property name="margin_bottom">60</property>
+                <property name="margin-left">100</property>
+                <property name="margin-right">100</property>
+                <property name="margin-top">100</property>
+                <property name="margin-bottom">60</property>
                 <property name="orientation">vertical</property>
                 <property name="spacing">12</property>
                 <child>
@@ -281,13 +281,13 @@
         </child>
         <child>
           <object class="GtkActionBar" id="updatesBar">
-            <property name="no_show_all">True</property>
+            <property name="no-show-all">True</property>
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
                 <property name="pixel-size">24</property>
                 <property name="margin">6</property>
-                <property name="icon_name">software-update-available-symbolic</property>
+                <property name="icon-name">software-update-available-symbolic</property>
                 <style>
                   <class name="warning"/>
                 </style>
@@ -321,13 +321,13 @@
                 <property name="visible">True</property>
                 <property name="valign">center</property>
                 <property name="action-name">win.logout</property>
-                <property name="receives_default">True</property>
+                <property name="receives-default">True</property>
                 <style>
                   <class name="suggested-action"/>
                 </style>
               </object>
               <packing>
-                <property name="pack_type">end</property>
+                <property name="pack-type">end</property>
               </packing>
             </child>
           </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]