[gjs/wip/smcv/test-more-flags: 273/273] testGIMarshalling: Expand test coverage for flags

[Philip Chimento <pchimento src gnome org>]

commit 31b92fbb26df9cee30c1a24773ea4ec9f057e111
Author: Simon McVittie <smcv debian org>
Date:   Sun Aug 23 18:42:23 2020 +0100

    testGIMarshalling: Expand test coverage for flags
    
    This requires a GObject-Introspection release with
    gobject-introspection!235 included.
    
    Signed-off-by: Simon McVittie <smcv debian org>

 installed-tests/js/testGIMarshalling.js | 55 +++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
---
diff --git a/installed-tests/js/testGIMarshalling.js b/installed-tests/js/testGIMarshalling.js
index 7573e8fc..84092aa4 100644
--- a/installed-tests/js/testGIMarshalling.js
+++ b/installed-tests/js/testGIMarshalling.js
@@ -450,6 +450,14 @@ describe('C array with length', function () {
         ]);
     });
 
+    describe('of flags', function () {
+        testInParameter('array_flags', [
+            GIMarshallingTests.Flags.VALUE1,
+            GIMarshallingTests.Flags.VALUE2,
+            GIMarshallingTests.Flags.VALUE3,
+        ]);
+    });
+
     it('marshals an array with a 64-bit length parameter', function () {
         expect(() => GIMarshallingTests.array_in_guint64_len([-1, 0, 1, 2])).not.toThrow();
     });
@@ -758,6 +766,11 @@ describe('GValue', function () {
             .not.toThrow();
     }).pend("GJS doesn't support native enum types");
 
+    xit('flags can be passed into a function and packed', function () {
+        expect(() => GIMarshallingTests.gvalue_in_flags(GIMarshallingTests.Flags.VALUE3))
+            .not.toThrow();
+    }).pend("we don't know to pack flags in a GValue as flags and not gint");
+
     it('marshals as an int64 out parameter', function () {
         expect(GIMarshallingTests.gvalue_int64_out()).toEqual(Limits.int64.max);
     });
@@ -1147,6 +1160,14 @@ let VFuncTester = GObject.registerClass(class VFuncTester extends GIMarshallingT
         return GIMarshallingTests.Enum.VALUE3;
     }
 
+    vfunc_vfunc_return_flags() {
+        return GIMarshallingTests.Flags.VALUE2;
+    }
+
+    vfunc_vfunc_out_flags() {
+        return GIMarshallingTests.Flags.VALUE3;
+    }
+
     vfunc_vfunc_return_object_transfer_none() {
         if (!this._returnObject)
             this._returnObject = new GIMarshallingTests.Object({int: 53});
@@ -1285,6 +1306,14 @@ describe('Virtual function', function () {
         expect(tester.vfunc_out_enum()).toEqual(GIMarshallingTests.Enum.VALUE3);
     });
 
+    it('marshals a flags return value', function () {
+        expect(tester.vfunc_return_flags()).toEqual(GIMarshallingTests.Flags.VALUE2);
+    });
+
+    it('marshals a flags out parameter', function () {
+        expect(tester.vfunc_out_flags()).toEqual(GIMarshallingTests.Flags.VALUE3);
+    });
+
     // These tests check what the refcount is of the returned objects; see
     // comments in gimarshallingtests.c.
     // Objects that are exposed in JS always have at least one reference (the
@@ -1342,6 +1371,12 @@ const WrongVFuncTester = GObject.registerClass(class WrongVFuncTester extends GI
     vfunc_vfunc_out_enum() {
     }
 
+    vfunc_vfunc_return_flags() {
+    }
+
+    vfunc_vfunc_out_flags() {
+    }
+
     vfunc_vfunc_return_object_transfer_none() {
     }
 
@@ -1431,6 +1466,26 @@ describe('Wrong virtual functions', function () {
         GLib.test_assert_expected_messages_internal('Gjs', 'testGIMarshalling.js', 0,
             'testVFuncReturnWrongValue');
     });
+
+    it('marshals a flags return value', function () {
+        GLib.test_expect_message('Gjs', GLib.LogLevelFlags.LEVEL_CRITICAL,
+            'JS ERROR: Error: Expected type flags for Return*undefined*');
+
+        expect(tester.vfunc_return_flags()).toEqual(0);
+
+        GLib.test_assert_expected_messages_internal('Gjs', 'testGIMarshalling.js', 0,
+            'testVFuncReturnWrongValue');
+    });
+
+    it('marshals a flags out parameter', function () {
+        GLib.test_expect_message('Gjs', GLib.LogLevelFlags.LEVEL_CRITICAL,
+            'JS ERROR: Error: Expected type flags for Argument*undefined*');
+
+        expect(tester.vfunc_out_flags()).toEqual(0);
+
+        GLib.test_assert_expected_messages_internal('Gjs', 'testGIMarshalling.js', 0,
+            'testVFuncReturnWrongValue');
+    });
 });
 
 describe('Inherited GObject', function () {